Skip to content

add automated-security-fixes endpoint#1188

Merged
gmlewis merged 2 commits intogoogle:masterfrom
cpanato:GH-1184
Jun 11, 2019
Merged

add automated-security-fixes endpoint#1188
gmlewis merged 2 commits intogoogle:masterfrom
cpanato:GH-1184

Conversation

@cpanato
Copy link
Copy Markdown
Contributor

@cpanato cpanato commented Jun 9, 2019

Adding automated-security-fixes endpoint

fixes: #1184

@cpanato
add automated-security-fixes endpoint
b5b0b29 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 9, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2019 •
edited
Loading

Codecov Report

Merging #1188 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   70.24%   70.24%   +<.01%     
==========================================
  Files          84       84              
  Lines        5878     5892      +14     
==========================================
+ Hits         4129     4139      +10     
- Misses        958      960       +2     
- Partials      791      793       +2
Impacted Files Coverage Δ
github/github.go 87.53% <ø> (ø) ⬆️
github/repos.go 67.5% <71.42%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a35880...c15847c. Read the comment docs.

gmlewis
gmlewis approved these changes Jun 9, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato!

LGTM.
I'll see if I can resolve the conflicts from the GitHub Web UI, then we'll await a second LGTM before merging.

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jun 9, 2019

Hi @cpanato, it looks like I don't have permission to merge the changes to your PR. I think there is an "Allow maintainers to push to PR" or something like that if you want to try enabling it.

$ git push git@github.com:cpanato/go-github cpanato-GH-1184
Counting objects: 7, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.75 KiB | 596.00 KiB/s, done.
Total 7 (delta 6), reused 0 (delta 0)
remote: Resolving deltas: 100% (6/6), completed with 6 local objects.
To github.com:cpanato/go-github
 ! [remote rejected] cpanato-GH-1184 -> cpanato-GH-1184 (permission denied)
error: failed to push some refs to 'git@github.com:cpanato/go-github'

Otherwise, you are doing to have to resolve the conflicts yourself because the GitHub web editor doesn't appear to be working currently. Sorry about that.

The only change that's needed is to move your new custom header after the other new one:

diff --git a/github/github.go b/github/github.go
index bfe0453..d6b75ee 100644
--- a/github/github.go
+++ b/github/github.go
@@ -140,6 +140,9 @@ const (
 
        // https://developer.github.com/changes/2019-05-29-update-branch-api/
        mediaTypeUpdatePullRequestBranchPreview = "application/vnd.github.lydian-preview+json"
+
+       // https://developer.github.com/changes/2019-06-04-automated-security-fixes/
+       mediaTypeRequiredAutomatedSecurityFixesPreview = "application/vnd.github.london-preview+json"
 )
 
 // A Client manages communication with the GitHub API.

@cpanato
Copy link
Copy Markdown
Contributor Author

cpanato commented Jun 10, 2019

@gmlewis the Allow maintainers to push to PR is checked. i will rebase :)

@gmlewis gmlewis requested a review from gauntface June 10, 2019 14:40
vaibhavsingh97
vaibhavsingh97 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Thanks, for the PR @cpanato 💖

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jun 11, 2019

Thank you, @cpanato and @vaibhavsingh97!

Merging.

@gmlewis gmlewis merged commit ae92061 into google:master Jun 11, 2019
@cpanato cpanato deleted the GH-1184 branch June 11, 2019 12:05
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@cpanato @gmlewis
Add Automated Security Fixes API preview endpoint (google#1188)
6c3cdb6 
Fixes google#1184.
@rvdh rvdh mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

@gauntface gauntface Awaiting requested review from gauntface

+1 more reviewer

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support preview Automated Security Fixes API

4 participants

@cpanato @gmlewis @vaibhavsingh97 @googlebot