Skip to content

authn: Add NewConfigKeychain to load a config from explicit path#1603

Merged
imjasonh merged 4 commits intogoogle:mainfrom
imjasonh:default-keychain-path
Apr 18, 2023
Merged

authn: Add NewConfigKeychain to load a config from explicit path#1603
imjasonh merged 4 commits intogoogle:mainfrom
imjasonh:default-keychain-path

Conversation

@imjasonh
Copy link
Copy Markdown
Contributor

Fixes #1595

cc @hasheddan

@imjasonh imjasonh requested a review from jonjohnsonjr March 16, 2023 13:58
@jonjohnsonjr
Copy link
Copy Markdown
Collaborator

Want to rebase this given the refresher stuff?

@imjasonh imjasonh force-pushed the default-keychain-path branch from 878df4d to 5080696 Compare April 18, 2023 15:52
@imjasonh imjasonh enabled auto-merge (squash) April 18, 2023 16:00
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #1603 (e72603c) into main (9aa45a1) will decrease coverage by 0.01%.
The diff coverage is 90.47%.

❗ Current head e72603c differs from pull request most recent head 677d403. Consider uploading reports for the commit 677d403 to get more accurate results

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
- Coverage   72.08%   72.08%   -0.01%     
==========================================
  Files         120      120              
  Lines        9782     9814      +32     
==========================================
+ Hits         7051     7074      +23     
- Misses       2011     2017       +6     
- Partials      720      723       +3     
Impacted Files Coverage Δ
pkg/authn/keychain.go 89.05% <87.23%> (-5.45%) ⬇️
pkg/v1/google/keychain.go 87.87% <100.00%> (+0.37%) ⬆️
pkg/v1/google/list.go 71.27% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for filepath-based authn.Keychain

3 participants