Allow setting Content-Type in crane edit manifest#1551
Allow setting Content-Type in crane edit manifest#1551jonjohnsonjr merged 1 commit intogoogle:mainfrom
Conversation
This uses the --media-type flag.
436bd12 to
4d05fe1
Compare
|
Edit: Jon is faster than I am! 😂 |
Codecov Report
@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
- Coverage 73.07% 72.74% -0.34%
==========================================
Files 117 118 +1
Lines 9082 9241 +159
==========================================
+ Hits 6637 6722 +85
- Misses 1780 1833 +53
- Partials 665 686 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I suppose I should report back that I successfully tested this PR for converting an image from Docker media types to OCI media types and all went well. 😄 |
Would a command just to OCIfy a docker image be helpful? That's something we've found a need for in the past and then punted on. |
|
Hmmm, as a flag to I ran into this while testing something else the first time, and it was only the second time that I was trying to OCI-ify an existing image that I decided to really bug Jon about it in earnest since it seemed like an easy win for the overall ergonomics of |
|
Mostly just to make Jon cringe, I'd be happy to write a Edit: I need to stop trying to have coherent thoughts in the evenings and the mornings apparently - that trivial version wouldn't work recursively, which limits the usefulness a bit (and |
I'm 99% sure there's a PR to do this somewhere. |
…ifest change (google/go-containerregistry#1551) Signed-off-by: Brian DeGeeter <brian@degeeter.net>
…ifest change (google/go-containerregistry#1551) Signed-off-by: Brian DeGeeter <brian@degeeter.net>
This uses the --media-type flag.