remove unnecessary nil check#3517
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3517 +/- ##
==========================================
- Coverage 73.26% 73.25% -0.02%
==========================================
Files 113 113
Lines 15065 15065
==========================================
- Hits 11038 11036 -2
- Misses 3261 3263 +2
Partials 766 766 ☔ View full report in Codecov by Sentry. |
sandeepvinayak
pushed a commit
to sandeepvinayak/go-cloud
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pubsub/pubsub.go:565: remove unnecessay nil check.
because
len(slice)where slice == nil is always equal to 0,staticcheckwill highlight this optimization with the following message:for reference: staticcheck S1009