Skip to content

Conversation

@pmuetschard
Copy link
Member

This is in preparation for most RPC calls requiring a replay device and cleans up a blurry separation of concerns.

This model is responsible for loading the geometry mesh data to be
shown in the geometry view. This is a refactoring change, which moves
the RPC logic out of the view into a model class.
This model is responsible for loading the memory data and observation
ranges. This is a refactoring change, which moves the RPC logic out of
the view into a model class. As a side-effect, fixes some timing issues
in the memory view.

Also: collapses observation, read and write ranges so that the observation
drop-down doesn't explode on draw calls that read from the application
pool and the read/write highlights don't have random gaps.
Renames the Thumbnails model to ImagesModel (Images is already used in
multiple places, sigh) and gives it the ability to load textures and
framebuffers.
@pmuetschard pmuetschard requested a review from ben-clayton August 1, 2018 21:23
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@pmuetschard pmuetschard merged commit 3338f6c into google:master Aug 2, 2018
@pmuetschard pmuetschard deleted the odr branch August 2, 2018 20:29
pmuetschard added a commit to pmuetschard/gapid that referenced this pull request Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants