[C++] Add Vector64 specialization for std::vector<bool>
#8757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
5ae220b to
3b73dc6
Compare
3b73dc6 to
1a59e8d
Compare
Collaborator
Author
|
@dbaileychess or @aardappel could I get a workflow approval? :D |
aardappel
previously approved these changes
Nov 5, 2025
aardappel
reviewed
Nov 5, 2025
Collaborator
Author
|
@aardappel I believe I have fixed the ci issue, could you rerun the pipeline for me? I think leaving the change in the test fbs is fine |
aardappel
approved these changes
Nov 17, 2025
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
* add vector64 specialization for vector<bool> * fix generated code --------- Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
* add vector64 specialization for vector<bool> * fix generated code --------- Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8688.
Adds a customization for CreateVector64 for
std::vector<bool>Modified the test_64 code to specifically test this specialization. Compilation fails when the changes in
flatbuffer_builder.hare commented out.