[Python] Fix various codegen problems #8292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - escaping keywords happens **after** converting the case: - currently, `table ClassT` generate `class = Class()` which is invalid Python; - imports in `one_file` mode use the filename rather than the type name when resolving module names; - use `filename_suffix` instead of the hardcoded `_generated` one; - generate empty files if no structs or enums are available. This makes the set of output files more predictable for Bazel.
This includes: - escaping keywords happens **after** converting the case: - currently, `table ClassT` generate `class = Class()` which is invalid Python; - imports in `one_file` mode use the filename rather than the type name when resolving module names; - use `filename_suffix` instead of the hardcoded `_generated` one; - generate empty files if no structs or enums are available. This makes the set of output files more predictable for Bazel.
dbaileychess
approved these changes
May 1, 2024
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* [Python] Fix various codegen problems. This includes: - escaping keywords happens **after** converting the case: - currently, `table ClassT` generate `class = Class()` which is invalid Python; - imports in `one_file` mode use the filename rather than the type name when resolving module names; - use `filename_suffix` instead of the hardcoded `_generated` one; - generate empty files if no structs or enums are available. This makes the set of output files more predictable for Bazel. * [Python] Fix various codegen problems. This includes: - escaping keywords happens **after** converting the case: - currently, `table ClassT` generate `class = Class()` which is invalid Python; - imports in `one_file` mode use the filename rather than the type name when resolving module names; - use `filename_suffix` instead of the hardcoded `_generated` one; - generate empty files if no structs or enums are available. This makes the set of output files more predictable for Bazel.
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* [Python] Fix various codegen problems. This includes: - escaping keywords happens **after** converting the case: - currently, `table ClassT` generate `class = Class()` which is invalid Python; - imports in `one_file` mode use the filename rather than the type name when resolving module names; - use `filename_suffix` instead of the hardcoded `_generated` one; - generate empty files if no structs or enums are available. This makes the set of output files more predictable for Bazel. * [Python] Fix various codegen problems. This includes: - escaping keywords happens **after** converting the case: - currently, `table ClassT` generate `class = Class()` which is invalid Python; - imports in `one_file` mode use the filename rather than the type name when resolving module names; - use `filename_suffix` instead of the hardcoded `_generated` one; - generate empty files if no structs or enums are available. This makes the set of output files more predictable for Bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
table ClassTgenerateclass = Class()which is invalid Python;one_filemode use the filename rather than the type name when resolving module names;filename_suffixinstead of the hardcoded_generatedone;