[Swift] Optional scalars code gen #6038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
lgtm. I think there's a newer version of @CasperN 's schema to test against. |
Collaborator
Author
|
Yeah I will be waiting for @CasperN's Pr to be merged then I will finalize this one |
378cd69 to
8c68c1c
Compare
7b8278a to
14e74c2
Compare
Adds swift test code Replaces if statments Adds swift to supported languages for optionals Small Fixes Finalize PR Moved std::string to auto Adds nullable scalars support in object api
ab5670c to
bec9461
Compare
ivannp
pushed a commit
to ivannp/flatbuffers
that referenced
this pull request
Oct 2, 2020
Adds swift test code Replaces if statments Adds swift to supported languages for optionals Moved std::string to auto Adds nullable scalars support in object api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Cpp Code Generator for optional scalars in swift.
This PR should be merged after #6034 since it already have a schema for optional scalars