Skip to content

Breadcrumb fix for sites with docs at the root#807

Merged
chalin merged 2 commits intogoogle:masterfrom
chalin:chalin-breadcrumb-for-docs-at-root-2021-12-15
Dec 17, 2021
Merged

Breadcrumb fix for sites with docs at the root#807
chalin merged 2 commits intogoogle:masterfrom
chalin:chalin-breadcrumb-for-docs-at-root-2021-12-15

Conversation

@chalin
Copy link
Collaborator

@chalin chalin commented Dec 15, 2021 •
edited
Loading

@chalin chalin force-pushed the chalin-breadcrumb-for-docs-at-root-2021-12-15 branch from d0e4129 to 924b735 Compare December 15, 2021 20:13
@chalin chalin requested review from LisaFC and emckean December 15, 2021 20:14
@chalin
Copy link
Collaborator Author

chalin commented Dec 17, 2021

@emckean gave a thumbs up out-of-band.
I'll go ahead a merge.
@LisaFC - comments are still welcome.

@chalin chalin merged commit 0428f46 into google:master Dec 17, 2021
@chalin chalin deleted the chalin-breadcrumb-for-docs-at-root-2021-12-15 branch December 17, 2021 12:22
@chalin chalin mentioned this pull request Dec 17, 2021
Closed
deining pushed a commit to deining/docsy that referenced this pull request Jan 4, 2022
@chalin @deining
Breadcrumb fix for sites with docs at the root (google#807)
2f90895
@gundamew gundamew mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emckean emckean Awaiting requested review from emckean

@LisaFC LisaFC Awaiting requested review from LisaFC

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

executing "partials/breadcrumb.html" at <.Parent.IsHome>: nil pointer evaluating page.Page.IsHome

1 participant

@chalin