Add click to copy button to code samples#1245
Merged
geriom merged 1 commit intogoogle:mainfrom Oct 6, 2022
Merged
Conversation
Adds a click to copy button to code samples that don't use the Prism highlighter.
Collaborator
Author
|
I'm going to merge this to include it in the release. I don't foresee any problems, but we can always roll it back in a revision release if there's a conflict. |
This was referenced Oct 8, 2022
Collaborator
There is an issue with BS. For details, see #1264. |
Collaborator
|
If / once this makes it into a published release, maybe it would be good to mention this wonderful new feature in the changelog? WDYT @geriom? |
This was referenced Oct 8, 2022
geriom
added a commit
to geriom/docsy
that referenced
this pull request
Feb 27, 2023
Refactor of google#1245, Bootstrap5-compatible code.
geriom
added a commit
to geriom/docsy
that referenced
this pull request
Feb 27, 2023
Refactor of google#1245, Bootstrap5-compatible code.
geriom
added a commit
to geriom/docsy
that referenced
this pull request
Feb 28, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
geriom
added a commit
to geriom/docsy
that referenced
this pull request
Feb 28, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
geriom
added a commit
to geriom/docsy
that referenced
this pull request
Feb 28, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
geriom
added a commit
to geriom/docsy
that referenced
this pull request
Mar 6, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
chalin
pushed a commit
to geriom/docsy
that referenced
this pull request
May 31, 2023
Refactor of PR google#1245. Bootstrap5-compatible code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a click to copy button to code samples that don't use the Prism highlighter.
This implementation requires the latest version of Popper. I ran a
grepon the whole website and couldn't find any other Popper instances. So it seems updating the Popper library won't affect anything.Screenshots