Drop FontAwesome static/webfonts file copies, mount package#1164
Merged
chalin merged 2 commits intogoogle:mainfrom Aug 15, 2022
Merged
Drop FontAwesome static/webfonts file copies, mount package#1164chalin merged 2 commits intogoogle:mainfrom
chalin merged 2 commits intogoogle:mainfrom
Conversation
This was referenced Aug 15, 2022
LisaFC
approved these changes
Aug 15, 2022
Collaborator
Author
|
Ok, I tested the use of this PR over the https://github.com/open-telemetry/opentelemetry.io. We can see that the webfont files get updated: $ cd themes/docsy && git switch chalin-im-drop-webfonts-2022-08-15
$ GET="no" npm run check-links
...
$ npm run cd:public -- git diff | grep ^diff | grep webfont
diff --git a/webfonts/fa-brands-400.eot b/webfonts/fa-brands-400.eot
diff --git a/webfonts/fa-brands-400.svg b/webfonts/fa-brands-400.svg
diff --git a/webfonts/fa-brands-400.ttf b/webfonts/fa-brands-400.ttf
diff --git a/webfonts/fa-brands-400.woff b/webfonts/fa-brands-400.woff
diff --git a/webfonts/fa-brands-400.woff2 b/webfonts/fa-brands-400.woff2
diff --git a/webfonts/fa-regular-400.eot b/webfonts/fa-regular-400.eot
diff --git a/webfonts/fa-regular-400.svg b/webfonts/fa-regular-400.svg
diff --git a/webfonts/fa-regular-400.ttf b/webfonts/fa-regular-400.ttf
diff --git a/webfonts/fa-regular-400.woff b/webfonts/fa-regular-400.woff
diff --git a/webfonts/fa-regular-400.woff2 b/webfonts/fa-regular-400.woff2
diff --git a/webfonts/fa-solid-900.eot b/webfonts/fa-solid-900.eot
diff --git a/webfonts/fa-solid-900.svg b/webfonts/fa-solid-900.svg
diff --git a/webfonts/fa-solid-900.ttf b/webfonts/fa-solid-900.ttf
diff --git a/webfonts/fa-solid-900.woff b/webfonts/fa-solid-900.woff
diff --git a/webfonts/fa-solid-900.woff2 b/webfonts/fa-solid-900.woff2And the FA icons continue to display fine. |
Collaborator
Author
|
I'm unsure how this will affect Docsy via Hugo Modules. @deining WDYT? |
Collaborator
Author
|
Will follow up via: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
This appropriately updates the webfont files and has no other (non-trivial) effect:
$ (cd userguide/public && g diff -- ':(exclude)*.map' ':(exclude)*webfonts*.*')In the diff above, the
@imports are the same, they've just moved slightly because we dropped the@fa-font-pathline.