Hilt: skip view injection in edit mode#4305
Closed
3dm1 wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Closes #4305 RELNOTES=Skip view injection when in edit mode for previews. PiperOrigin-RevId: 640680452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code change includes a check to skip injecting views in case
View#isInEditModereturnstrue, i.e. view is displayed in IDE's XML layout editor preview.Main driver for this change is that I'm running a BUCK project and can only reliably get the version of view classes that extend from the generated
Hilt_classes. These cannot be instantiated in the preview since the view injector requires an application context, which is unavailable.More importantly this is no-op in Gradle projects, since modified classes are never loaded by it, so there are no other side effects.