Conversation
This version contains rust-lang/mdBook#1986 which will allow us to test the code in each translation.
|
Just curious, why did you need to update ko.po? However, the formatting for the changed text in English looks like: And in Korean: I think the original text should have used ``` instead of `. The Korean translation seems wrong ;-) I'll fix it in a next round. |
The extra code block made `mdbook test` fail.
3da34e7 to
b178ad3
Compare
Yes, I completely agree: the formatting in English is weird and should be fixed there. I'm sorry I didn't spot that in #169 (@qwandor). The golden rule of working with i18n is that you cannot "fix" anything in the translations, apart from typos in the source text. You have to follow the original in terms of formatting, otherwise the two versions will start to drift apart and that makes your life very hard when it comes to tracking changes. |
* Update mdbook to 0.4.28 This version contains rust-lang/mdBook#1986 which will allow us to test the code in each translation. * Fix formatting in Korean translation The extra code block made `mdbook test` fail.
This version contains rust-lang/mdBook#1986 which will allow us to test the code in each translation.