Publish translations to /xx subdirectories#264
Merged
mgeisler merged 1 commit intogoogle:mainfrom Jan 24, 2023
Merged
Conversation
This publishes translations (currently only the Danish translation) to subdirectories named after the ISO 639-1 language code: “da/” for Danish, “ko/” for Korean, etc. The list of translation is an explicit list to make it easy for us to enable/disable translations without being tied to the files in po/. This allows us to experiment with a translation without publishing it immediately. I propose that we eventually move the English pages to an “en/” directory for symmetry with the other locales. However, for now, the pages remain at the room of our site (which works fine since we don’t have a subdirectory named “en/” in the course).
qwandor
approved these changes
Jan 24, 2023
Collaborator
Author
|
Thanks @qwandor, the very-incomplete Danish translation is now visible under https://google.github.io/comprehensive-rust/da/. @keispace, we can also publish the Korean translation now. |
NoahDragon
pushed a commit
to wnghl/comprehensive-rust
that referenced
this pull request
Jul 19, 2023
This publishes translations (currently only the Danish translation) to subdirectories named after the ISO 639-1 language code: “da/” for Danish, “ko/” for Korean, etc. The list of translation is an explicit list to make it easy for us to enable/disable translations without being tied to the files in po/. This allows us to experiment with a translation without publishing it immediately. I propose that we eventually move the English pages to an “en/” directory for symmetry with the other locales. However, for now, the pages remain at the room of our site (which works fine since we don’t have a subdirectory named “en/” in the course).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This publishes translations (currently only the Danish translation) to subdirectories named after the ISO 639-1 language code: “da/” for Danish, “ko/” for Korean, etc.
The list of translation is an explicit list to make it easy for us to enable/disable translations without being tied to the files in po/. This allows us to experiment with a translation without publishing it immediately.
I propose that we eventually move the English pages to an “en/” directory for symmetry with the other locales. However, for now, the pages remain at the room of our site (which works fine since we don’t have a subdirectory named “en/” in the course).