Skip to content

Update chromepolicy.go to follow the updated Chrome CT Policy#1067

Merged
roger2hk merged 5 commits intogoogle:masterfrom
breadyzhang:ct
May 15, 2023
Merged

Update chromepolicy.go to follow the updated Chrome CT Policy#1067
roger2hk merged 5 commits intogoogle:masterfrom
breadyzhang:ct

Conversation

@breadyzhang
Copy link
Copy Markdown
Contributor

@breadyzhang breadyzhang commented May 2, 2023 •
edited
Loading

  • Use LogGroupInfo in chromepolicy.go to keep track of the different CT log operators.
  • Change calculation of minimum number of SCTs using the lifetime in days.
  • Add extra fields in the safeSubmissionState struct to keep track of the distinct CT operators that have returned an SCT.
  • Add a check in groupComplete to check for distinct CT log operators before marking as a complete group.

Fixes #906

Checklist

@breadyzhang breadyzhang requested a review from a team as a code owner May 2, 2023 21:00
@breadyzhang breadyzhang requested review from getagit and removed request for a team May 2, 2023 21:00
@roger2hk roger2hk removed the request for review from getagit May 2, 2023 21:23
@roger2hk
Copy link
Copy Markdown
Contributor

roger2hk commented May 2, 2023

/gcbrun

1 similar comment
@roger2hk
Copy link
Copy Markdown
Contributor

roger2hk commented May 4, 2023

/gcbrun

@roger2hk
Copy link
Copy Markdown
Contributor

roger2hk commented May 4, 2023

@carlosjoan91 PTAL

carlosjoan91
carlosjoan91 approved these changes May 5, 2023
View reviewed changes
Copy link
Copy Markdown

@carlosjoan91 carlosjoan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roger2hk roger2hk self-requested a review May 9, 2023 09:19
roger2hk
roger2hk reviewed May 10, 2023
View reviewed changes
@breadyzhang
Update chromepolicy.go to follow the updated Chrome CT policy.
879103b 
Add extra fields to the safeSubmissionState struct that can keep track of how many distinct CT operators return an SCT and the minimum number of distinct CT log operators need to return an SCT.
@breadyzhang
updated CHANGELOG.md
b36ad9c
@breadyzhang
Use the number of seconds in the certificate lifetime to determine th…
d74c368 
…e number of required submissions to prevent any errors due to rounding and daylight savings time zone transitions.
roger2hk
roger2hk reviewed May 10, 2023
View reviewed changes
@roger2hk roger2hk requested a review from AlCutter May 11, 2023 18:20
@roger2hk
Copy link
Copy Markdown
Contributor

roger2hk commented May 11, 2023

@AlCutter This PR looks good to me but it would be better to have another pair of eyes.

@roger2hk roger2hk merged commit e6f5d49 into google:master May 15, 2023
@breadyzhang breadyzhang mentioned this pull request May 17, 2023
Closed
@breadyzhang breadyzhang mentioned this pull request Sep 20, 2023
Merged
breadyzhang added a commit to breadyzhang/certificate-transparency-go that referenced this pull request Sep 20, 2023
@breadyzhang
revert google#1067
6c7ac17
@breadyzhang breadyzhang mentioned this pull request Sep 20, 2023
Merged
2 tasks
roger2hk pushed a commit that referenced this pull request Sep 20, 2023
@breadyzhang
Revert "Update chromepolicy.go to follow the updated Chrome CT Policy" (
95a25da 
#1154)

* revert #1067

* add license comment back in

---------

Co-authored-by: breadyzhang <zhangfreddy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roger2hk roger2hk roger2hk approved these changes

@AlCutter AlCutter AlCutter approved these changes

+2 more reviewers

@pphaneuf pphaneuf pphaneuf left review comments

@carlosjoan91 carlosjoan91 carlosjoan91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating chromepolicy.go

5 participants

@breadyzhang @roger2hk @pphaneuf @carlosjoan91 @AlCutter