Revert "Add d postfix to Debug libraries"#947
Merged
Conversation
dmah42
reviewed
Mar 16, 2020
dmah42
approved these changes
Mar 16, 2020
4f098d0 to
70d89ac
Compare
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
This reverts commit 5ce2429. Reverts google#923 Reopens google#922 Fixes google#928 Closes google#930 See discussion in google#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ce2429.
Reverts #923
Reopens #922
Fixes #928
Closes #930
See discussion in #928
this broke pkg-config support, since there we don't account
for the suffix, nor is it trivial to do so.