Remove stray comment and added missing header#1444
Merged
dmah42 merged 1 commit intogoogle:mainfrom Jul 26, 2022
Merged
Conversation
Member
oontvoo
commented
Jul 25, 2022
- The export.h is no longer generated, so removed the comment.
- Added export.h to benchmark_main
- The export.h is no longer generated, so removed the comment. - Added export.h to benchmark_main
Member
Author
dmah42
approved these changes
Jul 25, 2022
sergiud
added a commit
to sergiud/benchmark
that referenced
this pull request
Sep 27, 2022
…e#1435)" This reverts commit 7b3ac07. Revert "Fix SOVERSION of shared library" This reverts commit d4bc509. Revert "Also fix the SOVERSION for benchmark_main" This reverts commit d845b7b. Revert "use target_compile_definitions (google#1440)" This reverts commit e27c930. Revert "Remove stray comment and added missing header (google#1444)" This reverts commit 141b554. Revert "remove unnecessary generated include directory (google#1451)" This reverts commit 7d48eff.
sergiud
added a commit
to sergiud/benchmark
that referenced
this pull request
Sep 27, 2022
…e#1435)" This reverts commit 7b3ac07. Revert "Fix SOVERSION of shared library" This reverts commit d4bc509. Revert "Also fix the SOVERSION for benchmark_main" This reverts commit d845b7b. Revert "Remove stray comment and added missing header (google#1444)" This reverts commit 141b554. Revert "remove unnecessary generated include directory (google#1451)" This reverts commit 7d48eff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.