When building AutoValue, pick up AutoService via <annotationProcessorPaths>.
#1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47a7ff1 to
b94e22f
Compare
…rPaths>`. The annotation dependencies for `@AutoService` and for Error Prone are now regular compile-scoped dependencies. This prevents errors from overeager consumers that can't deal with missing annotation class files. The `<annotationProcessorPaths>` incantations are kind of clunky since we need a different path for building tests (which must include AutoValueProcessor) and for building AutoValue itself (which obviously can't). Fixes #1032. RELNOTES=n/a PiperOrigin-RevId: 367010584
b94e22f to
a2f647f
Compare
tbroyer
reviewed
Apr 6, 2021
| <path> | ||
| <groupId>com.google.auto.value</groupId> | ||
| <artifactId>auto-value</artifactId> | ||
| <version>HEAD-SNAPSHOT</version> |
Contributor
There was a problem hiding this comment.
That could (should?) probably be ${project.version}
Member
There was a problem hiding this comment.
Thanks, yes, that seems better.
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
…sorPaths>`. The annotation dependency for `@AutoService` is now a regular compile-scoped dependency. This prevents errors from overeager consumers that can't deal with missing annotation class files. This change is equivalent to the one we made for AutoValue in #1046. RELNOTES=AutoService dependency is now a regular compile-scoped dependency. PiperOrigin-RevId: 367219456
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
…sorPaths>`. The annotation dependency for `@AutoService` is now a regular compile-scoped dependency. This prevents errors from overeager consumers that can't deal with missing annotation class files. This change is equivalent to the one we made for AutoValue in #1046. Fixes #744. RELNOTES=AutoService dependency is now a regular compile-scoped dependency. PiperOrigin-RevId: 367219456
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
…sorPaths>`. The annotation dependency for `@AutoService` is now a regular compile-scoped dependency. This prevents errors from overeager consumers that can't deal with missing annotation class files. This change is equivalent to the one we made for AutoValue in #1046. Fixes #744. RELNOTES=AutoService dependency is now a regular compile-scoped dependency. PiperOrigin-RevId: 367221859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building AutoValue, pick up AutoService via
<annotationProcessorPaths>.The annotation dependencies for
@AutoServiceand for Error Prone are now regular compile-scoped dependencies. This prevents errors from overeager consumers that can't deal with missing annotation class files.The
<annotationProcessorPaths>incantations are kind of clunky since we need a different path for building tests (which must include AutoValueProcessor) and for building AutoValue itself (which obviously can't).Fixes #1032.
RELNOTES=n/a