Support using a debug app check provider during configuration #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
reviewed
Aug 25, 2023
andrewheard
reviewed
Aug 30, 2023
Samples/Swift/AppAttestExample/AppAttestExample/AppAttestExampleApp.swift
Outdated
Show resolved
Hide resolved
andrewheard
approved these changes
Aug 30, 2023
yalkhder
approved these changes
Aug 30, 2023
andrewheard
suggested changes
Sep 5, 2023
yalkhder
approved these changes
Sep 8, 2023
andrewheard
reviewed
Sep 8, 2023
GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m
Show resolved
Hide resolved
andrewheard
approved these changes
Sep 8, 2023
GoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h
Outdated
Show resolved
Hide resolved
yalkhder
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
-[GIDSignIn configureWithCompletion:]to be-[GIDSignIn configureDebugProviderWithAPIKey:completion:]so that clients can specify using a debug app check provider (e.g., when running on the simulator).