Add required conversions to any subscription callback#8
Merged
gonzodepedro merged 2 commits intogonzo/non-transform-intra-process-working-testsfrom Dec 8, 2021
Conversation
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
clalancette
approved these changes
Dec 8, 2021
Collaborator
clalancette
left a comment
There was a problem hiding this comment.
One small nit, but otherwise generally looks good to me. I was able to compile and test things locally, with just the linters failing (we'll address that separately).
| } | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Nit: extra space here.
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
clalancette
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Add required conversions to any subscription callback Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Removed extra space Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
gonzodepedro
added a commit
that referenced
this pull request
Dec 20, 2021
* Add required conversions to any subscription callback * Style fixes for the linters. (#9) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Add required conversions to any subscription callback * Style fixes for the linters. (#9) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
clalancette
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Add required conversions to any subscription callback * Style fixes for the linters. (#9) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar