Clarify the template types#7
Merged
gonzodepedro merged 5 commits intogonzodepedro:gonzo/non-transform-intra-process-working-testsfrom Dec 8, 2021
Merged
Conversation
Owner
|
Rebase needed? |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
f46f561 to
d60dcb5
Compare
1085608
into
gonzodepedro:gonzo/non-transform-intra-process-working-tests
clalancette
added a commit
that referenced
this pull request
Dec 17, 2021
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
gonzodepedro
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Dec 20, 2021
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Jan 4, 2022
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * More clarification of the types. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very verbose PR that explicitly calls out all of the types that are being use in the intra-process code, both on the publisher side and subscriber side. Along with that, there are a bunch of fixes in here to actually use the correct types now that they are clearer. With this in place, we are a lot closer to having correct types, though we still need a very thorough review of the Allocator and Deleter types before everything will work.