Push the publish conversion down to the intra-process manager#6
Merged
gonzodepedro merged 4 commits intogonzodepedro:gonzo/non-transform-intra-process-working-testsfrom Dec 8, 2021
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It makes it easier to determine which type we are talking about. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
There really is no functional change here, just preparing to move the conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
e9ec5e2
into
gonzodepedro:gonzo/non-transform-intra-process-working-tests
clalancette
added a commit
that referenced
this pull request
Dec 17, 2021
* Remove template defaults that we never use. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Rename MessageT to PublishedType in the IntraProcessManager. It makes it easier to determine which type we are talking about. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Get all the types setup to push the conversion down to IPM. There really is no functional change here, just preparing to move the conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Move conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
gonzodepedro
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Remove template defaults that we never use. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Rename MessageT to PublishedType in the IntraProcessManager. It makes it easier to determine which type we are talking about. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Get all the types setup to push the conversion down to IPM. There really is no functional change here, just preparing to move the conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Move conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Dec 20, 2021
* Remove template defaults that we never use. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Rename MessageT to PublishedType in the IntraProcessManager. It makes it easier to determine which type we are talking about. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Get all the types setup to push the conversion down to IPM. There really is no functional change here, just preparing to move the conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Move conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Jan 4, 2022
* Remove template defaults that we never use. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Rename MessageT to PublishedType in the IntraProcessManager. It makes it easier to determine which type we are talking about. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Get all the types setup to push the conversion down to IPM. There really is no functional change here, just preparing to move the conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Move conversion down to the intra-process manager. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is, we delay the conversion until the call to
IntraProcessManager::do_intra_process_publish_and_return_shared. This still ends up in double-conversion, but at least it is hidden away in the IntraProcessManager for now. We'll have to revisit this to make it do less work later.