Skip to content

lapack/gonum: add dtgsy2#1669

Closed
soypat wants to merge 31 commits intogonum:masterfrom
soypat:dtgsy2
Closed

lapack/gonum: add dtgsy2#1669
soypat wants to merge 31 commits intogonum:masterfrom
soypat:dtgsy2

Conversation

@soypat
Copy link
Contributor

@soypat soypat commented Jun 13, 2021

Related: ARE issue #1651

No transpose solve implemented. Missing transpose. PR submitted as a draft for review as it progresses.

Missing Dgesc2 (#1652 ) and Dlatdf (#1658 ) implementations.

Three new errors added for D and E matrix arguments as well as a bad ijob value.

@soypat soypat marked this pull request as draft June 13, 2021 22:23
kortschak
kortschak reviewed Jun 13, 2021
View reviewed changes
@soypat soypat mentioned this pull request Jun 14, 2021
Merged
@soypat
Copy link
Contributor Author

soypat commented Jun 20, 2021

@vladimir-ch Please take a look. I think we should first have trans == blas.Trans passing since it makes no use of Dlatdf, a function which I have yet not been able to test.

@soypat soypat changed the title lapack/gonum: add dtgsy2 without transpose lapack/gonum: add dtgsy2 Jun 20, 2021
@soypat
Copy link
Contributor Author

soypat commented Jun 20, 2021 •
edited
Loading

So here's some news, Dtgsy2 is passing Trans tests (disregard the commit name, it is not passing trans==NoTrans tests.) Would it be reasonable to add Dlatdf with this routine? As far as I know there is no other way to test Dlatdf

@kortschak
Copy link
Member

kortschak commented Jun 20, 2021

Can we have a little less pushing while working? Each build eats into a fairly limited supply of Travis build credits.

@soypat
Copy link
Contributor Author

soypat commented Jun 20, 2021

Can we have a little less pushing while working? Each build eats into a fairly limited supply of Travis build credits.

Heck, I had no idea! I'm sorry. I'll keep Pushes to a minimum.

@kortschak
Copy link
Member

kortschak commented Jun 21, 2021

No worries.

soypat
soypat commented Jun 22, 2021
View reviewed changes
soypat
soypat commented Jun 22, 2021
View reviewed changes
soypat
soypat commented Jun 22, 2021
View reviewed changes
@soypat
Copy link
Contributor Author

soypat commented Jun 22, 2021 •
edited
Loading

It's passing tests on my machine! I cannot for the life of me find the bug in the following block:

  • nb==2 && mb == 2 for trans == blas.NoTrans with ijob == 0 (Dlatdf is not running)

I'm gonna take a break for a while, this one is killing me.

@soypat soypat marked this pull request as ready for review June 22, 2021 02:45
@soypat soypat marked this pull request as draft June 24, 2021 02:20
@soypat
Copy link
Contributor Author

soypat commented Oct 21, 2021

Closed due to git rot in favor of new fork https://github.com/soypat/gonum/tree/dtgsy2

@soypat soypat closed this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kortschak kortschak kortschak left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soypat @kortschak