add lapack dlatdf routine#1658
Closed
soypat wants to merge 19 commits intogonum:masterfrom
soypat:dlatdf
Closed
Conversation
Contributor
Author
|
PTAL |
Contributor
Author
|
I will make a new PR with Dlatdf. This one has a lot of noise in the files with unwanted changes. |
Member
|
I recommend that in general you finish the implementation and its test, make sure that it passes locally and that the coverage is as complete as reasonably possible and only then submit a PR. Learning git (including rebasing) will also help keeping changes clean and under control. |
Contributor
Author
|
Closing due to git rot. Will be PRing from a new repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With respect to CARE solver to begin resolving #1651. Requires #1652 to be merged to have Dgesc2 (see lines 73-74)