Port all http apis as stubs to the registry service #1884
Merged
mschuwalow merged 4 commits intomainfrom Aug 5, 2025
Merged
Conversation
afsalthaj
reviewed
Aug 5, 2025
| } | ||
| } | ||
|
|
||
| declare_unions! { |
Contributor
There was a problem hiding this comment.
Could you quickly tell me the need of this macros? Just curious, and I may get why when I get deeper into PR reviews.
afsalthaj
reviewed
Aug 5, 2025
| #[cfg_attr(feature = "poem", derive(poem_openapi::Union))] | ||
| #[cfg_attr(feature = "poem", oai(discriminator_name = "type", one_of = true))] | ||
| #[serde(tag = "type")] | ||
| $i |
Contributor
There was a problem hiding this comment.
Oh okay. Discard my previous comment. Makes sense.
afsalthaj
approved these changes
Aug 5, 2025
mschuwalow
added a commit
that referenced
this pull request
Aug 15, 2025
This reverts commit 204faec.
vigoo
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1878