unix: fix Listen on solaris by jwntree · Pull Request #258 · golang/sys

jwntree · 2025-07-30T11:00:51Z

libsocket has __xnet_listen, not __xnet_llisten
which prevents listen from working.

libsocket has __xnet_listen, not __xnet_llisten

gopherbot · 2025-07-30T11:06:27Z

This PR (HEAD: 6f37c4b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/691735.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-30T11:14:38Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-30T11:22:09Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-02T18:29:30Z

Message from 나지원:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T11:26:54Z

Message from 나지원:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:04:09Z

Message from Jes Cok:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:11:26Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-08-30T13:55:17Z","revision":"6cdbc9cb8eb427b77e5cd93b89e93bdb45b147e1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:11:26Z

Message from Jes Cok:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:11:27Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:11:27Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:25:52Z

Message from Keith Randall:

Patch Set 2: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-30T14:25:53Z

Message from Keith Randall:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-31T12:52:49Z

Message from Jes Cok:

Patch Set 2: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:34:14Z

Message from Tobias Klauser:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:51:23Z

Message from Emmanuel Odeke:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T11:29:38Z

Message from 나지원:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T11:37:41Z

Message from 나지원:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T12:47:14Z

Message from Tobias Klauser:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T12:55:54Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-05T12:40:59Z","revision":"d212f0a6ba800a9343d34ecb6326a89b62afec57"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T12:55:55Z

Message from Tobias Klauser:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T12:55:56Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T12:55:56Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-05T13:21:06Z

Message from Emmanuel Odeke:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/691735.
After addressing review feedback, remember to publish your drafts!

libsocket has __xnet_listen, not __xnet_llisten which prevents listen from working. Change-Id: Ia06dc569fcb9950893d91fc1b86257c7742e9e3d GitHub-Last-Rev: 6f37c4b GitHub-Pull-Request: #258 Reviewed-on: https://go-review.googlesource.com/c/sys/+/691735 Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Jes Cok <xigua67damn@gmail.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>

gopherbot · 2025-09-05T15:24:47Z

This PR is being closed because golang.org/cl/691735 has been merged.

unix : fix Listen on solaris

6f37c4b

libsocket has __xnet_listen, not __xnet_llisten

jwntree changed the title ~~unix : fix Listen() on solaris~~ unix : fix Listen on solaris Aug 2, 2025

jwntree changed the title ~~unix : fix Listen on solaris~~ unix: fix Listen on solaris Aug 2, 2025

gopherbot closed this Sep 5, 2025

Conversation

jwntree commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 30, 2025

Uh oh!

gopherbot commented Jul 30, 2025

Uh oh!

gopherbot commented Jul 30, 2025

Uh oh!

gopherbot commented Aug 2, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 30, 2025

Uh oh!

gopherbot commented Aug 31, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

gopherbot commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jwntree commented Jul 30, 2025 •

edited

Loading