unix: add IFAL_* consts and ifaddrlblmsg on linux by juanluisvaladas · Pull Request #252 · golang/sys

juanluisvaladas · 2025-06-24T20:00:34Z

Implments consts and structs related to ifaddrlabel

gopherbot · 2025-06-24T20:06:43Z

This PR (HEAD: fb77b37) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/683775.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-24T20:14:15Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-24T20:14:20Z

This PR (HEAD: ea35581) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/683775.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-24T20:21:10Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-12T10:26:07Z

This PR (HEAD: f2b0734) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/683775.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-08-12T10:42:44Z

Message from Juan Valadas:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-12T11:06:49Z

This PR (HEAD: 11be45c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/683775.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-01T12:14:03Z

Message from Juan Valadas:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-01T19:07:48Z

Message from Florian Lehner:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:34:11Z

Message from Tobias Klauser:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:42:44Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-02T14:25:07Z","revision":"973ddb9813afc104ad1a637b43473f106a999e64"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:42:45Z

Message from Tobias Klauser:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:42:46Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-02T14:42:46Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

Implments consts and structs related to ifaddrlabel Change-Id: I6dd78e74a8e32a26286b95b0a7a20343cb16a446 GitHub-Last-Rev: 11be45c GitHub-Pull-Request: #252 Reviewed-on: https://go-review.googlesource.com/c/sys/+/683775 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Florian Lehner <lehner.florian86@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>

gopherbot · 2025-09-03T15:38:06Z

Message from Michael Pratt:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683775.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-03T15:46:20Z

This PR is being closed because golang.org/cl/683775 has been merged.

Since golang/sys#252 merged, we don't need to define these constants here anymore. Instead we can rely on golang standard library. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>

juanluisvaladas force-pushed the add-ifal branch from fb77b37 to ea35581 Compare June 24, 2025 20:11

juanluisvaladas mentioned this pull request Jun 24, 2025

Fix CPLB userspace on ipv6 only clusters by using address labels k0sproject/k0s#6010

Merged

16 tasks

juanluisvaladas force-pushed the add-ifal branch from ea35581 to f2b0734 Compare August 12, 2025 10:21

unix: add IFAL_* consts and ifaddrlblmsg on linux

11be45c

juanluisvaladas force-pushed the add-ifal branch from f2b0734 to 11be45c Compare August 12, 2025 11:05

gopherbot closed this Sep 3, 2025

juanluisvaladas mentioned this pull request Sep 15, 2025

Replace Ifaddrlbl structs and consts with sys/unix k0sproject/k0s#6398

Merged

16 tasks

Conversation

juanluisvaladas commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jun 24, 2025

Uh oh!

gopherbot commented Jun 24, 2025

Uh oh!

gopherbot commented Jun 24, 2025

Uh oh!

gopherbot commented Jun 24, 2025

Uh oh!

gopherbot commented Aug 12, 2025

Uh oh!

gopherbot commented Aug 12, 2025

Uh oh!

gopherbot commented Aug 12, 2025

Uh oh!

gopherbot commented Sep 1, 2025

Uh oh!

gopherbot commented Sep 1, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 2, 2025

Uh oh!

gopherbot commented Sep 3, 2025

Uh oh!

gopherbot commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

juanluisvaladas commented Jun 24, 2025 •

edited

Loading