Skip to content

x/sys/windows: use SyscallN in mkwinsyscall#171

Closed
mauri870 wants to merge 1 commit intogolang:masterfrom
mauri870:mkwinsyscall-more-params
Closed

x/sys/windows: use SyscallN in mkwinsyscall#171
mauri870 wants to merge 1 commit intogolang:masterfrom
mauri870:mkwinsyscall-more-params

Conversation

@mauri870
Copy link
Copy Markdown
Member

@mauri870 mauri870 commented Aug 12, 2023 •
edited
Loading

The mkwinsyscall command has a hard limit of 15 on the
number of syscall arguments. Windows has several system
calls with more than 15 arguments, for example CreateFontPackage
has 18 arguments.

If the number of arguments is higher than 15 we use SyscallN.

Fixes golang/go#57914

@mauri870 mauri870 changed the title x/sys/windows: use SyscallN in mkwinsyscall x/sys/windows: Using SyscallN in mkwinsyscall Aug 12, 2023
@mauri870 mauri870 changed the title x/sys/windows: Using SyscallN in mkwinsyscall x/sys/windows: using SyscallN in mkwinsyscall Aug 12, 2023
@mauri870 mauri870 changed the title x/sys/windows: using SyscallN in mkwinsyscall x/sys/windows: use SyscallN in mkwinsyscall Aug 12, 2023
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

This PR (HEAD: fffa8e2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

Message from Alex Brainman:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

Message from Mauri de Souza Meneguzzo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@mauri870 mauri870 force-pushed the mkwinsyscall-more-params branch 2 times, most recently from a929c3a to e1f3de4 Compare August 12, 2023 14:29
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

This PR (HEAD: e1f3de4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@mauri870 mauri870 force-pushed the mkwinsyscall-more-params branch from e1f3de4 to 0cd54e8 Compare August 12, 2023 14:36
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

Message from Mauri de Souza Meneguzzo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

This PR (HEAD: 0cd54e8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 12, 2023

Message from Alex Brainman:

Patch Set 4: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 13, 2023

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 13, 2023

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@mauri870 mauri870 force-pushed the mkwinsyscall-more-params branch from 0cd54e8 to 52272be Compare August 13, 2023 14:48
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 13, 2023

This PR (HEAD: 52272be) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@mauri870
x/sys/windows: use SyscallN in mkwinsyscall
1f1e96f 
The mkwinsyscall command has a hard limit of 15 on the
number of syscall arguments. Windows has several system
calls with more than 15 arguments, for example CreateFontPackage
has 18 arguments.

If the number of arguments is higher than 15 we use SyscallN.

Updates golang/go#57914
@mauri870 mauri870 force-pushed the mkwinsyscall-more-params branch from 52272be to 1f1e96f Compare August 13, 2023 14:52
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 13, 2023

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 13, 2023

This PR (HEAD: 1f1e96f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/518995.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Alex Brainman:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Alex Brainman:

Patch Set 6: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 14, 2023

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 16, 2023

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 16, 2023

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 16, 2023

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 16, 2023

Message from Ian Lance Taylor:

Patch Set 6: Auto-Submit+1 Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/518995.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 17, 2023
@mauri870 @gopherbot
windows: use SyscallN in mkwinsyscall
ad02017 
The mkwinsyscall command has a hard limit of 15 on the
number of syscall arguments. Windows has several system
calls with more than 15 arguments, for example CreateFontPackage
has 18 arguments.

If the number of arguments is higher than 15 we use SyscallN.

Fixes golang/go#57914

Change-Id: I4205e779a960ae10c0778de7876154e0d7ec00a1
GitHub-Last-Rev: 1f1e96f
GitHub-Pull-Request: #171
Reviewed-on: https://go-review.googlesource.com/c/sys/+/518995
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Aug 17, 2023

This PR is being closed because golang.org/cl/518995 has been merged.

@gopherbot gopherbot closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/sys/windows: mkwinsyscall: support syscalls with more than 15 params

2 participants

@mauri870 @gopherbot