unix: fix last argument of pselect6 on linux by mauri870 · Pull Request #167 · golang/sys

mauri870 · 2023-07-16T18:04:41Z

On Linux, the last argument of pselect6 system call is not a
sigseg_t * pointer, but instead it is a structure of the form:

struct {
    const sigset_t *ss;     /* Pointer to signal set */
    size_t          ss_len; /* Size (in bytes) of object pointed
};

See man 2 pselect6.

Fixes #61251

On Linux, the last argument of pselect6 system call is **not** a sigseg_t * pointer, but instead it is a structure of the form: struct { const sigset_t *ss; /* Pointer to signal set */ size_t ss_len; /* Size (in bytes) of object pointed }; See man 2 pselect6. Fixes #61251

gopherbot · 2023-07-16T18:14:30Z

This PR (HEAD: 3c1041b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-16T18:20:16Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-16T23:48:07Z

Message from Jesse Rittner:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-17T18:28:29Z

This PR (HEAD: b77b37a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-17T21:55:41Z

Message from Bryan Mills:

Patch Set 2: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-17T22:12:35Z

Message from Mauri de Souza Meneguzzo:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-17T22:23:47Z

Message from Mauri de Souza Meneguzzo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-17T22:34:56Z

This PR (HEAD: 29a4f6b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-18T05:15:44Z

Message from Ian Lance Taylor:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T14:51:49Z

Message from Bryan Mills:

Patch Set 3: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T20:33:05Z

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T20:38:50Z

This PR (HEAD: 364d4d2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-18T20:44:22Z

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T21:23:33Z

This PR (HEAD: cb3c6d7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/510195.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-18T21:29:11Z

Message from Mauri de Souza Meneguzzo:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-18T21:29:12Z

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-19T00:01:45Z

Message from Ian Lance Taylor:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-19T00:01:45Z

Message from Ian Lance Taylor:

Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510195.
After addressing review feedback, remember to publish your drafts!

On Linux, the last argument of pselect6 system call is **not** a sigseg_t * pointer, but instead it is a structure of the form: struct { const sigset_t *ss; /* Pointer to signal set */ size_t ss_len; /* Size (in bytes) of object pointed }; See man 2 pselect6. Fixes #61251 Change-Id: Id0aa122a77796713bc6d624dc395d396fbc0c5e2 GitHub-Last-Rev: cb3c6d7 GitHub-Pull-Request: #167 Reviewed-on: https://go-review.googlesource.com/c/sys/+/510195 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>

gopherbot · 2023-07-19T00:07:20Z

This PR is being closed because golang.org/cl/510195 has been merged.

s/pselect6Sigset_t/sigset_argpack/g

b77b37a

mauri870 added 2 commits July 17, 2023 19:26

chore: inline cast

92541e6

refactor(linux): replace Pselect with pselect6 for Select

29a4f6b

mauri870 changed the title ~~linux: fix last argument of pselect6~~ unix: fix last argument of pselect6 Jul 18, 2023

mauri870 changed the title ~~unix: fix last argument of pselect6~~ unix: fix last argument of pselect6 on linux Jul 18, 2023

chore: remove unused for loop in test

364d4d2

chore: add doc comment about timeout value in Pselect

cb3c6d7

gopherbot closed this Jul 19, 2023

Conversation

mauri870 commented Jul 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 16, 2023

Uh oh!

gopherbot commented Jul 16, 2023

Uh oh!

gopherbot commented Jul 16, 2023

Uh oh!

gopherbot commented Jul 17, 2023

Uh oh!

gopherbot commented Jul 17, 2023

Uh oh!

gopherbot commented Jul 17, 2023

Uh oh!

gopherbot commented Jul 17, 2023

Uh oh!

gopherbot commented Jul 17, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 18, 2023

Uh oh!

gopherbot commented Jul 19, 2023

Uh oh!

gopherbot commented Jul 19, 2023

Uh oh!

gopherbot commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mauri870 commented Jul 16, 2023 •

edited

Loading