This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Generate imports in sorted path order#2
Closed
peterstace wants to merge 1 commit intogolang:masterfrom
peterstace:master
Closed
Generate imports in sorted path order#2peterstace wants to merge 1 commit intogolang:masterfrom peterstace:master
peterstace wants to merge 1 commit intogolang:masterfrom
peterstace:master
Conversation
This ensures that the import order is consistent between multiple runs of mockgen (rather than in random map iteration order). This is useful to help avoid noisy diffs for the case where multiple mocks are regenerated automatically but not all of the mocked interfaces have changed.
Contributor
|
Doesn't the generated code get pushed through the |
Contributor
Author
|
The generated code doesn't get pushed through I'll close this pull request and put up a new one that uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the import order is consistent between multiple runs of mockgen (rather than in random map iteration order). This is useful to help avoid noisy diffs for the case where multiple mocks are regenerated automatically but not all of the mocked interfaces have changed.