Skip to content

crypto/tls: send illegal_parameter on invalid ECHClientHello.type#71062

Closed
thekuwayama wants to merge 1 commit intogolang:masterfrom
thekuwayama:errInvalidECHExt_alertIllegalParameter
Closed

crypto/tls: send illegal_parameter on invalid ECHClientHello.type#71062
thekuwayama wants to merge 1 commit intogolang:masterfrom
thekuwayama:errInvalidECHExt_alertIllegalParameter

Conversation

@thekuwayama
Copy link
Copy Markdown
Contributor

@thekuwayama thekuwayama commented Dec 29, 2024 •
edited by dmitshur
Loading

The spec indicates that if a client sends an invalid ECHClientHello.type
in ClientHelloOuter, the server will abort the handshake with a
decode_error alert.

Define errInvalidECHExt for invalid ECHClientHello.type. If parseECHExt
returns an errInvalidECHExt error, Conn now sends an illegal_parameter
alert.

Fixes #71061.

@thekuwayama
crypto/tls: if received an invalid ECHClientHello.type, server send a…
3d6c233 
… illegal_parameter

The spec indicates that if a client sends an invalid ECHClientHello.type in
ClientHelloOuter, the server will abort the handshake with a decode_error
alert. Defined errInvalidECHExt for invalid ECHClientHello.type. If
parseECHExt returns an errInvalidECHExt error, Conn now sends an
illegal_parameter alert.

Fixes golang#71061
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 29, 2024

This PR (HEAD: 3d6c233) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/639235.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 29, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Roland Shoemaker:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-30T17:10:58Z","revision":"ce55c045c4a692f8fc69ec49ea7673760a5da5fd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Roland Shoemaker:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Roland Shoemaker:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur changed the title crypto/tls: if received an invalid ECHClientHello.type, server send a illegal_parameter crypto/tls: send illegal_parameter on invalid ECHClientHello.type Dec 30, 2024
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Dec 30, 2024

Message from Dmitri Shuralyov:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/639235.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 7, 2025
@thekuwayama @rolandshoemaker
crypto/tls: send illegal_parameter on invalid ECHClientHello.type
850b276 
The spec indicates that if a client sends an invalid ECHClientHello.type
in ClientHelloOuter, the server will abort the handshake with a
decode_error alert.

Define errInvalidECHExt for invalid ECHClientHello.type. If parseECHExt
returns an errInvalidECHExt error, Conn now sends an illegal_parameter
alert.

Fixes #71061.

Change-Id: I240241fe8bbe3e77d6ad1af989794647bfa2ff87
GitHub-Last-Rev: 3d6c233
GitHub-Pull-Request: #71062
Reviewed-on: https://go-review.googlesource.com/c/go/+/639235
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Jan 7, 2025

This PR is being closed because golang.org/cl/639235 has been merged.

@gopherbot gopherbot closed this Jan 7, 2025
mingyech pushed a commit to refraction-networking/utls that referenced this pull request Mar 1, 2025
@thekuwayama @rolandshoemaker
crypto/tls: send illegal_parameter on invalid ECHClientHello.type
51c7999 
The spec indicates that if a client sends an invalid ECHClientHello.type
in ClientHelloOuter, the server will abort the handshake with a
decode_error alert.

Define errInvalidECHExt for invalid ECHClientHello.type. If parseECHExt
returns an errInvalidECHExt error, Conn now sends an illegal_parameter
alert.

Fixes #71061.

Change-Id: I240241fe8bbe3e77d6ad1af989794647bfa2ff87
GitHub-Last-Rev: 3d6c233ccd401453bfb1a4fc97fa5deeb5b2fbc8
GitHub-Pull-Request: golang/go#71062
Reviewed-on: https://go-review.googlesource.com/c/go/+/639235
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto/tls: server should send a illegal_parameter alert when it received an invalid ECHClientHello.type

2 participants

@thekuwayama @gopherbot