crypto,hash: add t.Helper calls to test helpers by apocelipes · Pull Request #68843 · golang/go

apocelipes · 2024-08-12T11:19:35Z

Use t.Helper to make the reported failure lines more helpful.

gopherbot · 2024-08-12T11:24:56Z

This PR (HEAD: 0a600e8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-12T11:32:00Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-12T11:39:20Z

Message from kyose chang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-12T18:09:05Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-13T04:17:33Z

This PR (HEAD: 397e321) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-13T04:24:38Z

Message from kyose chang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-13T23:13:03Z

Message from Ian Lance Taylor:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

Use t.Helper to make the reported failure lines more helpful.

gopherbot · 2024-08-14T03:49:38Z

This PR (HEAD: 2e020ea) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-14T04:24:35Z

Message from kyose chang:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T13:52:04Z

Message from Ian Lance Taylor:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T13:52:04Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-08-14T13:36:38Z","revision":"a66f237cfb5005c2feb603db79f2ef5c926ee922"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T14:14:30Z

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T14:14:30Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T14:14:31Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T17:04:59Z

Message from Ian Lance Taylor:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T17:05:00Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-08-14T16:55:25Z","revision":"a66f237cfb5005c2feb603db79f2ef5c926ee922"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T17:26:53Z

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-14T17:26:54Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/604755.
After addressing review feedback, remember to publish your drafts!

Use t.Helper to make the reported failure lines more helpful. Change-Id: I6593924b3892b2441a197aee4e05f71ea236d426 GitHub-Last-Rev: 2e020ea GitHub-Pull-Request: #68843 Reviewed-on: https://go-review.googlesource.com/c/go/+/604755 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-08-15T20:24:33Z

This PR is being closed because golang.org/cl/604755 has been merged.

Use t.Helper to make the reported failure lines more helpful. Change-Id: I6593924b3892b2441a197aee4e05f71ea236d426 GitHub-Last-Rev: 2e020ea85cf44c6cc0e90cb919eb0d7bb5a1c315 GitHub-Pull-Request: golang/go#68843 Reviewed-on: https://go-review.googlesource.com/c/go/+/604755 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

apocelipes force-pushed the feat-add-missing-thelper branch 2 times, most recently from 77fabdb to 397e321 Compare August 13, 2024 04:15

crypto,hash: add t.Helper calls to test helpers

2e020ea

Use t.Helper to make the reported failure lines more helpful.

apocelipes force-pushed the feat-add-missing-thelper branch from 397e321 to 2e020ea Compare August 14, 2024 03:48

gopherbot closed this Aug 15, 2024

apocelipes deleted the feat-add-missing-thelper branch August 20, 2024 17:51

Conversation

apocelipes commented Aug 12, 2024

Uh oh!

gopherbot commented Aug 12, 2024

Uh oh!

gopherbot commented Aug 12, 2024

Uh oh!

gopherbot commented Aug 12, 2024

Uh oh!

gopherbot commented Aug 12, 2024

Uh oh!

gopherbot commented Aug 13, 2024

Uh oh!

gopherbot commented Aug 13, 2024

Uh oh!

gopherbot commented Aug 13, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 14, 2024

Uh oh!

gopherbot commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants