net/http: check GetConfigForClient in server.ServeTLS by chancez · Pull Request #66795 · golang/go

chancez · 2024-04-12T01:06:10Z

Just like for tls.Config.GetCertificate the http.Server.ServeTLS method
should be checking tls.Config.GetConfigForClient before trying top open
the specified certFile/keyFile.

This was previously fixed for crypto/tls when using tls.Listen in
CL205059, but the same change for net/http was missed. I've added a
comment src/crypto/tls/tls.go in the relevant section in the hope that
any future changes of a similar nature consider will consider updating
net/http as needed as well.

gopherbot · 2024-04-12T01:10:26Z

This PR (HEAD: c27b963) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578396.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-12T01:16:24Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-12T12:59:46Z

Message from qiulaidongfeng:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-12T13:05:59Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-12T12:49:05Z","revision":"4b48be261e0010f8cca7fa13e854b95afcef2ccd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-12T13:12:43Z

Message from qiulaidongfeng:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-12T13:12:43Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-12T13:12:44Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-12T15:48:54Z

Message from Chance Zibolski:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T18:36:14Z

Message from Damien Neil:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-17T17:30:35Z

Message from Cherry Mui:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-06T22:32:50Z

Message from Chance Zibolski:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-06T22:32:50Z

Message from Filippo Valsorda:

Patch Set 2: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

Just like for tls.Config.GetCertificate the http.Server.ServeTLS method should be checking tls.Config.GetConfigForClient before trying top open the specified certFile/keyFile. This was previously fixed for crypto/tls when using tls.Listen in CL205059, but the same change for net/http was missed. I've added a comment src/crypto/tls/tls.go in the relevant section in the hope that any future changes of a similar nature consider will consider updating net/http as needed as well. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>

gopherbot · 2024-06-07T15:24:13Z

This PR (HEAD: 6ed29a9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578396.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-07T15:31:32Z

Message from Chance Zibolski:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:12:24Z

Message from Damien Neil:

Patch Set 3: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:19:12Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-07T16:01:05Z","revision":"43326dbea998e62ba9e5999d8bb55f790ed6c139"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:19:12Z

Message from Damien Neil:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:19:13Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 578396)
tools on master (commit 15d13c3)

Build or test failure, click here for results.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:19:13Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:58:59Z

Message from Damien Neil:

Patch Set 4: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T16:58:59Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-07T16:52:54Z","revision":"aa291a2662e2be166352a792b4f2d4d631b423b2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T17:19:01Z

Message from Damien Neil:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T17:19:01Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-07T17:19:02Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578396.
After addressing review feedback, remember to publish your drafts!

Just like for tls.Config.GetCertificate the http.Server.ServeTLS method should be checking tls.Config.GetConfigForClient before trying top open the specified certFile/keyFile. This was previously fixed for crypto/tls when using tls.Listen in CL205059, but the same change for net/http was missed. I've added a comment src/crypto/tls/tls.go in the relevant section in the hope that any future changes of a similar nature consider will consider updating net/http as needed as well. Change-Id: I312303bc497d92aa2f4627fe2620c70779cbcc99 GitHub-Last-Rev: 6ed29a9 GitHub-Pull-Request: #66795 Reviewed-on: https://go-review.googlesource.com/c/go/+/578396 Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>

gopherbot · 2024-06-07T18:07:05Z

This PR is being closed because golang.org/cl/578396 has been merged.

Just like for tls.Config.GetCertificate the http.Server.ServeTLS method should be checking tls.Config.GetConfigForClient before trying top open the specified certFile/keyFile. This was previously fixed for crypto/tls when using tls.Listen in CL205059, but the same change for net/http was missed. I've added a comment src/crypto/tls/tls.go in the relevant section in the hope that any future changes of a similar nature consider will consider updating net/http as needed as well. Change-Id: I312303bc497d92aa2f4627fe2620c70779cbcc99 GitHub-Last-Rev: 6ed29a900816a13690a9f3e26476d9bc1055a6f7 GitHub-Pull-Request: golang/go#66795 Reviewed-on: https://go-review.googlesource.com/c/go/+/578396 Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>

chancez force-pushed the http_server_tls_check_GetConfigForClient branch from c27b963 to 6ed29a9 Compare June 7, 2024 15:20

gopherbot closed this Jun 7, 2024

chancez deleted the http_server_tls_check_GetConfigForClient branch June 7, 2024 20:15

HadrienPatte mentioned this pull request May 27, 2025

tls: Remove mock TLS config GetCertificate method cilium/cilium#39753

Merged

8 tasks

Conversation

chancez commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 12, 2024

Uh oh!

gopherbot commented Apr 16, 2024

Uh oh!

gopherbot commented Apr 17, 2024

Uh oh!

gopherbot commented Jun 6, 2024

Uh oh!

gopherbot commented Jun 6, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

gopherbot commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chancez commented Apr 12, 2024 •

edited

Loading