net/http: allow multiple spaces between method and path in mux patterns by callthingsoff · Pull Request #65868 · golang/go

callthingsoff · 2024-02-22T04:45:07Z

Fixes #64910

gopherbot · 2024-02-22T04:48:52Z

This PR (HEAD: 6657b24) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T04:54:45Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T04:54:46Z

Message from Jes Cok:

Patch Set 1: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T04:54:46Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-22T04:50:14Z","revision":"494db81ebe13b58ce8f918b57e192d5dde51512a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T05:25:18Z

Message from Jes Cok:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T05:25:19Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T05:25:19Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T05:31:23Z

This PR (HEAD: cdafa22) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T11:43:56Z

Message from Jonathan Amsterdam:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T11:56:49Z

Message from Jes Cok:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T12:16:27Z

Message from Jonathan Amsterdam:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T12:29:33Z

Message from Jes Cok:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T12:50:04Z

Message from Jonathan Amsterdam:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T14:09:37Z

This PR (HEAD: 0b99ffc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T14:16:41Z

This PR (HEAD: 5b7fe40) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T14:30:55Z

Message from Jes Cok:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T14:51:21Z

Message from Frederik Zipp:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T15:07:04Z

This PR (HEAD: b5459ca) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T15:14:07Z

Message from Jes Cok:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T20:44:31Z

Message from Jonathan Amsterdam:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T23:22:34Z

This PR (HEAD: 74bcf91) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T23:29:12Z

Message from Jes Cok:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T17:40:58Z

Message from Jonathan Amsterdam:

Patch Set 6: Code-Review+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T21:31:30Z

This PR (HEAD: 918a6db) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-23T21:43:41Z

Message from Jes Cok:

Patch Set 7: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T21:49:43Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-23T21:35:47Z","revision":"6d106c049ded253a61932b6e64d5e72c78cae104"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T21:56:00Z

Message from Jes Cok:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T21:56:01Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):

FAILURE

go on master (change 565916)

Tests failed. See all test results.

Error:
shard 2: failed to run "go tool dist test -json": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T21:56:01Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T22:02:33Z

Message from Jes Cok:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T02:18:48Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T02:18:49Z

Message from Jes Cok:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T03:35:38Z

Message from Jes Cok:

Patch Set 8: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T03:35:39Z

Message from Gopher Robot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T03:47:31Z

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T03:47:32Z

Message from Jes Cok:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T03:53:30Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-24T03:37:54Z","revision":"85d1585ae1551243c6bd36edc763bd8c95811123"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T04:05:24Z

Message from Jes Cok:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T04:05:25Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T04:05:25Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T11:46:33Z

Message from Jes Cok:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T11:52:43Z

This PR (HEAD: b8d436c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565916.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-24T11:58:35Z

Message from Jes Cok:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T11:58:35Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-24T11:53:40Z","revision":"23813a021a8e36a66b3179cfbff97cc386fd6535"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T12:23:20Z

Message from Jes Cok:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T12:23:21Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-24T12:23:21Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T12:04:45Z

Message from Jonathan Amsterdam:

Patch Set 9: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T12:04:45Z

Message from Jonathan Amsterdam:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T12:04:46Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-26T11:56:12Z","revision":"23813a021a8e36a66b3179cfbff97cc386fd6535"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T12:24:56Z

Message from Jonathan Amsterdam:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T12:24:56Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T16:32:37Z

Message from Damien Neil:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

Fixes #64910 Change-Id: I14fd1e35c95b14591e3ad7b889dc1ab19a008730 GitHub-Last-Rev: b8d436c GitHub-Pull-Request: #65868 Reviewed-on: https://go-review.googlesource.com/c/go/+/565916 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>

gopherbot · 2024-02-26T16:45:56Z

Message from Jonathan Amsterdam:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565916.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T16:53:30Z

This PR is being closed because golang.org/cl/565916 has been merged.

Fixes #64910 Change-Id: I14fd1e35c95b14591e3ad7b889dc1ab19a008730 GitHub-Last-Rev: b8d436cdee93d103703e7e6d4bb28315c5035300 GitHub-Pull-Request: golang/go#65868 Reviewed-on: https://go-review.googlesource.com/c/go/+/565916 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>

re7

b8d436c

gopherbot closed this Feb 26, 2024

callthingsoff deleted the http_pattern_multi_spaces branch February 26, 2024 17:01

Uh oh!

Conversation

callthingsoff commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 23, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!

gopherbot commented Feb 24, 2024

Uh oh!