crypto/tls: fix typo in comment by testwill · Pull Request #65836 · golang/go

testwill · 2024-02-21T07:14:14Z

No description provided.

gopherbot · 2024-02-21T07:18:18Z

This PR (HEAD: 4040d77) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565440.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-21T09:02:40Z

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T09:02:40Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-21T08:54:16Z","revision":"02145d9b3c9e67336cf528e9d272df53f0e65814"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T09:29:11Z

Message from qiulaidongfeng:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T09:29:11Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T09:29:12Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T18:59:30Z

Message from Ian Lance Taylor:

Patch Set 2: Commit message was updated.

Copied Votes:

Code-Review+1 (copy condition: "is:ANY")
LUCI-TryBot-Result+1 (copy condition: "changekind:NO_CODE_CHANGE")

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T18:59:31Z

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:12:58Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-21T18:50:59Z","revision":"e071aee1cb873aa30cc0d7d383e9e34ce54c8d2c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:12:59Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

LUCI-TryBot-Result-1 has been copied to patch set 3 (was LUCI-TryBot-Result+1) (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:13:00Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-21T18:59:36Z","revision":"92e4bb98815774f98b8c6b4f0f886a81e3096b0c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:19:59Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:32:46Z

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:32:47Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T19:32:47Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>

gopherbot · 2024-02-22T01:32:10Z

This PR (HEAD: 7ce7d01) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/565440.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T01:38:31Z

Message from guoguangwu guo:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T02:03:26Z

Message from Ian Lance Taylor:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T02:10:06Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-22T01:56:26Z","revision":"0aa199aa3d84ad263512967c9271a5ba8878b6a7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T02:22:00Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T02:22:01Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T02:22:01Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

Change-Id: I77371ef99797e2b53f1292c9d6a4eb157f116f88 GitHub-Last-Rev: 7ce7d01 GitHub-Pull-Request: #65836 Reviewed-on: https://go-review.googlesource.com/c/go/+/565440 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-02-26T21:43:04Z

Message from Carlos Amedee:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565440.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T21:49:15Z

This PR is being closed because golang.org/cl/565440 has been merged.

Change-Id: I77371ef99797e2b53f1292c9d6a4eb157f116f88 GitHub-Last-Rev: 7ce7d014c0c46b320f9e4b742ae9360d1b5cf4dc GitHub-Pull-Request: golang/go#65836 Reviewed-on: https://go-review.googlesource.com/c/go/+/565440 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

testwill force-pushed the tls_fix branch from 4040d77 to 097e975 Compare February 22, 2024 01:30

crypto/tls: fix typo in comment

7ce7d01

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>

testwill force-pushed the tls_fix branch from 097e975 to 7ce7d01 Compare February 22, 2024 01:31

testwill changed the title ~~crypto/tls: fix comment error~~ crypto/tls: fix typo in comment Feb 22, 2024

gopherbot closed this Feb 26, 2024

testwill deleted the tls_fix branch February 27, 2024 01:02

Conversation

testwill commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 26, 2024

Uh oh!

gopherbot commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants