Skip to content

os/exec: document a method to check if a process is alive#60763

Closed
mpldr wants to merge 1 commit intogolang:masterfrom
mpldr-pulls:34396-add-docs
Closed

os/exec: document a method to check if a process is alive#60763
mpldr wants to merge 1 commit intogolang:masterfrom
mpldr-pulls:34396-add-docs

Conversation

@mpldr
Copy link
Contributor

@mpldr mpldr commented Jun 13, 2023 •
edited
Loading

Fixes #34396

@gopherbot
Copy link
Contributor

gopherbot commented Jun 13, 2023

This PR (HEAD: cb59f88) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/502815 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jun 13, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 14, 2023

Message from Moritz Poldrack:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 14, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 15, 2023

Message from Moritz Poldrack:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 15, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

This PR (HEAD: 4c9e2bf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/502815 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Moritz Poldrack:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Ian Lance Taylor:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

This PR (HEAD: 4f06764) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/502815 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Moritz Poldrack:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 16, 2023

Message from Ian Lance Taylor:

Patch Set 3: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/502815.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 17, 2023
@mpldr @gopherbot
os/exec: document a method to check if a process is alive
261e267 
Fixes #34396

Change-Id: I35c4e3447f84e349adf7edba92ccb19b324bfe14
GitHub-Last-Rev: 4f06764
GitHub-Pull-Request: #60763
Reviewed-on: https://go-review.googlesource.com/c/go/+/502815
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Jun 17, 2023

This PR is being closed because golang.org/cl/502815 has been merged.

@gopherbot gopherbot closed this Jun 17, 2023
@ferrmin ferrmin mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

os: FindProcess should document how to test if a process is alive since on UNIX it always returns a process

2 participants

@mpldr @gopherbot