Skip to content

cmd/compile/internal/types: fix typo in comment#46598

Closed
HeGaoYuan wants to merge 1 commit into
golang:masterfrom
HeGaoYuan:patch-1
Closed

cmd/compile/internal/types: fix typo in comment#46598
HeGaoYuan wants to merge 1 commit into
golang:masterfrom
HeGaoYuan:patch-1

Conversation

@HeGaoYuan

@HeGaoYuan HeGaoYuan commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Why there are two // in this line ?
@google-cla

google-cla Bot commented Jun 6, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jun 6, 2021
@HeGaoYuan

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jun 6, 2021
@HeGaoYuan HeGaoYuan changed the title Update type.go go/types: typo Jun 6, 2021
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: cdb3235) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/325510 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/325510.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Robert Griesemer:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/325510.
After addressing review feedback, remember to publish your drafts!

@HeGaoYuan HeGaoYuan changed the title go/types: typo cmd/compile/internal/types: fix typo in comment Jun 6, 2021
@HeGaoYuan

Copy link
Copy Markdown
Contributor Author

/comments off

gopherbot pushed a commit that referenced this pull request Jul 25, 2024
Change-Id: Iacf22578338c8aa99587826a8342e1da6dc166a6
GitHub-Last-Rev: cdb3235
GitHub-Pull-Request: #46598
Reviewed-on: https://go-review.googlesource.com/c/go/+/325510
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
@gopherbot gopherbot closed this Jul 25, 2024
gopherbot pushed a commit to golang/crypto that referenced this pull request May 21, 2026
parseEd25519Key and parseEd25519Cert cast wire bytes
to ed25519.PrivateKey without checking length; a short
payload panics at priv[32:] in Public().

Fixes CVE-2026-46598
Fixes golang/go#46598

Change-Id: I127bc6a22adff1c4beb4d54533062bebc388de47
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/781360
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Nicholas Husin <nsh@golang.org>
Reviewed-by: Nicholas Husin <husin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants