Add: Quota Command to Manage Quotas#97
Merged
Merged
Conversation
16 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Closed
Member
|
@bupd issues need to be resolved. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new quota command to manage project quotas, addressing issue #96. The key changes include:
- New interactive views and a form for updating quota parameters.
- Implementation of list, view, and update commands in the quota module.
- Updates to the API and prompt layers to support quota management.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/views/quota/update/view.go | Introduces a new view for updating quotas with interactive inputs. |
| pkg/views/quota/select/view.go | Adds selection view for choosing a quota. |
| pkg/views/quota/list/view.go | Implements a table list view for displaying quotas. |
| pkg/prompt/prompt.go | Adds prompt function to get quota IDs from the user. |
| pkg/api/types.go | Introduces new flag types for quota listing. |
| pkg/api/quota_handler.go | Adds functions for listing, getting, and updating quotas. |
| cmd/harbor/root/quota/view.go | Implements the view quota command using the new API and list view. |
| cmd/harbor/root/quota/update.go | Implements quota update command and storage string parsing. |
| cmd/harbor/root/quota/update_test.go | Adds tests for storage string conversion. |
| cmd/harbor/root/quota/list.go | Adds the quota list command. |
| cmd/harbor/root/quota/cmd.go | Integrates the new quota commands into the CLI. |
| cmd/harbor/root/cmd.go | Updates the root command to include quota management. |
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Member
Author
|
@rizul2108 can you help testing this out. |
rizul2108
pushed a commit
to rizul2108/harbor-cli
that referenced
this pull request
May 24, 2025
* add: quota `list` command Signed-off-by: bupd <bupdprasanth@gmail.com> * add: quota `view` command Signed-off-by: bupd <bupdprasanth@gmail.com> * add: quota `update` command Signed-off-by: bupd <bupdprasanth@gmail.com> * add: unit test for quota update Signed-off-by: bupd <bupdprasanth@gmail.com> * fix lint Signed-off-by: bupd <bupdprasanth@gmail.com> * fix quota list cmd Signed-off-by: bupd <bupdprasanth@gmail.com> * fix quota view cmd Signed-off-by: bupd <bupdprasanth@gmail.com> * update quota view Signed-off-by: bupd <bupdprasanth@gmail.com> * fix quota cmd Signed-off-by: bupd <bupdprasanth@gmail.com> * add docs Signed-off-by: bupd <bupdprasanth@gmail.com> * fix lint issues Signed-off-by: bupd <bupdprasanth@gmail.com> --------- Signed-off-by: bupd <bupdprasanth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
This PR adds quota commands to manage quota of projects.
Screenshots:
Quota List command:
Quota Update:
Quota View: