fix(user): pass populated PasswordChangeView to ResetPassword#734
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
=========================================
- Coverage 10.99% 7.53% -3.46%
=========================================
Files 173 261 +88
Lines 8671 13012 +4341
=========================================
+ Hits 953 980 +27
- Misses 7612 11922 +4310
- Partials 106 110 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c0ff146 to
0d34f87
Compare
Add basic unit tests for password command to improve coverage. Signed-off-by: yimtun <yim.tune@gmail.com>
0d34f87 to
eb9e6c2
Compare
Contributor
|
@bupd could we get this merged? since someone else wants to solve an issue related to the user password command. ContextCurrent parameter, which is |
AMAN-sharma07
pushed a commit
to AMAN-sharma07/harbor-cli
that referenced
this pull request
Mar 26, 2026
…or#734) Add basic unit tests for password command to improve coverage. Signed-off-by: yimtun <yim.tune@gmail.com>
NishchayRajput
pushed a commit
to NishchayRajput/harbor-cli
that referenced
this pull request
Mar 28, 2026
…or#734) Add basic unit tests for password command to improve coverage. Signed-off-by: yimtun <yim.tune@gmail.com> Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where
resetViewwas not passed toapi.ResetPassword.The interactive password input populates
resetView, but the API call usedopts, which may not contain the updated password.This PR passes the populated
resetViewto the API instead.