Skip to content

refactor(artifact): refactoring scan and tag subcommands under artifacts#700

Merged
bupd merged 5 commits into
goharbor:mainfrom
NucleoFusion:feat/refactor-artifacts
Mar 17, 2026
Merged

refactor(artifact): refactoring scan and tag subcommands under artifacts#700
bupd merged 5 commits into
goharbor:mainfrom
NucleoFusion:feat/refactor-artifacts

Conversation

@NucleoFusion

Copy link
Copy Markdown
Contributor

The current structure has the scan and tags subcommand under the artifact root command in one singular file and not the correct file structure

…ct commands

Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@codecov

codecov Bot commented Feb 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 149 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.45%. Comparing base (60ad0bd) to head (e9f511c).
⚠️ Report is 118 commits behind head on main.

Files with missing lines Patch % Lines
cmd/harbor/root/artifact/tags/list.go 0.00% 33 Missing ⚠️
cmd/harbor/root/artifact/tags/create.go 0.00% 26 Missing ⚠️
cmd/harbor/root/artifact/tags/delete.go 0.00% 26 Missing ⚠️
cmd/harbor/root/artifact/scan/scan.go 0.00% 21 Missing ⚠️
cmd/harbor/root/artifact/scan/start.go 0.00% 15 Missing ⚠️
cmd/harbor/root/artifact/scan/stop.go 0.00% 15 Missing ⚠️
cmd/harbor/root/artifact/tags/tags.go 0.00% 11 Missing ⚠️
cmd/harbor/root/artifact/cmd.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #700      +/-   ##
=========================================
- Coverage   10.99%   7.45%   -3.54%     
=========================================
  Files         173     266      +93     
  Lines        8671   12924    +4253     
=========================================
+ Hits          953     964      +11     
- Misses       7612   11851    +4239     
- Partials      106     109       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qcserestipy qcserestipy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd

bupd commented Mar 3, 2026

Copy link
Copy Markdown
Member

@NucleoFusion please check and fix the lint issues - https://github.com/goharbor/harbor-cli/actions/runs/22627389260/attempts/1#summary-65567647631

Thanks for the contribution.

@bupd bupd added bug Something isn't working Changes Requesed feedback that must be addressed before merging. labels Mar 3, 2026
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
Signed-off-by: NucleoFusion <lakshit.singh.mail@gmail.com>
@NucleoFusion

Copy link
Copy Markdown
Contributor Author

@bupd solved!

@bupd bupd merged commit a08cb1f into goharbor:main Mar 17, 2026
6 of 8 checks passed
AMAN-sharma07 pushed a commit to AMAN-sharma07/harbor-cli that referenced this pull request Mar 26, 2026
…cts (goharbor#700)

Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
NishchayRajput pushed a commit to NishchayRajput/harbor-cli that referenced this pull request Mar 28, 2026
…cts (goharbor#700)

Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Changes Requesed feedback that must be addressed before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants