fix: pluralise time units in created time output#691
Merged
Conversation
Signed-off-by: Aditya Pratap Singh Shekhawat <adityashekhawat@Adityas-MacBook-Air.local>
e4ce3bd to
840a9c4
Compare
qcserestipy
reviewed
Feb 16, 2026
qcserestipy
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution! However, our project policy requires that every PR is linked to a pre-existing, approved issue. Could you please open an issue describing the pluralisation bug first and reference it in this PR? Without a linked issue, we'll need to close this PR. Thanks for understanding!
Contributor
Author
Thanks i have opened the issue |
NucleoFusion
approved these changes
Mar 12, 2026
NucleoFusion
left a comment
Contributor
There was a problem hiding this comment.
lgtm
Thanks for the contribution
AMAN-sharma07
pushed a commit
to AMAN-sharma07/harbor-cli
that referenced
this pull request
Mar 26, 2026
NishchayRajput
pushed a commit
to NishchayRajput/harbor-cli
that referenced
this pull request
Mar 28, 2026
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the UX of by fixing the pluralisation of time units in the Created Time output (for example, displaying “2 hours ago” instead of “2 hour ago”).
Changes
Before:
After:
Note
This is a small UX improvement so i addressed it directly in a PR rather than opening a separate issue first.