Skip to content

fix(member): add username validation in member creation view#615

Merged
bupd merged 2 commits into
goharbor:mainfrom
intojhanurag:fix/validate-name-util-package
Jan 22, 2026
Merged

fix(member): add username validation in member creation view#615
bupd merged 2 commits into
goharbor:mainfrom
intojhanurag:fix/validate-name-util-package

Conversation

@intojhanurag

@intojhanurag intojhanurag commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Description

Implements username validation in the member creation view by addressing the TODO comment on line 89 of [pkg/views/member/create/view.go]

Changes

  • Added validation for username format using existing utils.ValidateUserName() function

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Related Issues

Resolves the TODO comment in pkg/views/member/create/view.go:89

@intojhanurag

intojhanurag commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Hey @bupd , PTAL :)

@bupd bupd self-assigned this Jan 21, 2026
@bupd bupd added the enhancement New feature or request label Jan 21, 2026
@codecov

codecov Bot commented Jan 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.45%. Comparing base (60ad0bd) to head (dbaeb3e).
⚠️ Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
pkg/views/member/create/view.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             main    #615      +/-   ##
=========================================
- Coverage   10.99%   6.45%   -4.54%     
=========================================
  Files         173     260      +87     
  Lines        8671   12845    +4174     
=========================================
- Hits          953     829     -124     
- Misses       7612   11910    +4298     
  Partials      106     106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bupd
bupd approved these changes Jan 22, 2026
View reviewed changes

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

intojhanurag and others added 2 commits January 22, 2026 06:02
@intojhanurag @bupd
fix(member): add username validation in member creation view
285203c 
Signed-off-by: intojhanurag <aojharaj2004@gmail.com>
@bupd
fix: error message validate username
dbaeb3e 
Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd bupd force-pushed the fix/validate-name-util-package branch from fa5eab5 to dbaeb3e Compare January 22, 2026 00:32
@bupd bupd merged commit 13e1f9e into goharbor:main Jan 22, 2026
6 of 8 checks passed
@intojhanurag intojhanurag deleted the fix/validate-name-util-package branch January 22, 2026 04:32
Vickysomtee pushed a commit to Vickysomtee/harbor-cli that referenced this pull request Feb 4, 2026
@intojhanurag @bupd @Vickysomtee
fix(member): add username validation in member creation view (goharbo…
0d8a0b2 
…r#615)

Co-authored-by: bupd <bupdprasanth@gmail.com>
@BrewTestBot BrewTestBot mentioned this pull request Feb 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bupd bupd bupd approved these changes

Assignees

@bupd bupd

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@intojhanurag @bupd