Skip to content

Fix: Sign All Published Image Tags#612

Merged
bupd merged 1 commit into
goharbor:mainfrom
bupd:fix-rel
Jan 21, 2026
Merged

Fix: Sign All Published Image Tags#612
bupd merged 1 commit into
goharbor:mainfrom
bupd:fix-rel

Conversation

@bupd

@bupd bupd commented Jan 20, 2026

Copy link
Copy Markdown
Member

Summary

Only the first image tag was being signed when multiple tags were published during releases.

Changes

  • Loop through all imageAddrs and sign each one in PublishImageAndSign
  • Include image address in error message for better debugging

Fixes #611

@bupd
fix: missing sign for multiple tags release workflow
2fb8d49 
Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd bupd self-assigned this Jan 20, 2026
@bupd bupd added bug Something isn't working go Pull requests that update go code labels Jan 20, 2026
@codecov

codecov Bot commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 6.45%. Comparing base (60ad0bd) to head (2fb8d49).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##             main    #612      +/-   ##
=========================================
- Coverage   10.99%   6.45%   -4.54%     
=========================================
  Files         173     260      +87     
  Lines        8671   12843    +4172     
=========================================
- Hits          953     829     -124     
- Misses       7612   11908    +4296     
  Partials      106     106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

NucleoFusion
NucleoFusion approved these changes Jan 21, 2026
View reviewed changes

@NucleoFusion NucleoFusion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd bupd merged commit 2176bf8 into goharbor:main Jan 21, 2026
7 of 8 checks passed
@bupd bupd deleted the fix-rel branch January 21, 2026 19:12
Vickysomtee pushed a commit to Vickysomtee/harbor-cli that referenced this pull request Feb 4, 2026
@bupd @Vickysomtee
fix: missing sign for multiple tags release workflow (goharbor#612)
7670139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NucleoFusion NucleoFusion NucleoFusion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bupd bupd

Labels

bug Something isn't working go Pull requests that update go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix: Sign All Published Image Tags

2 participants

@bupd @NucleoFusion