repository: reject any updates that has symlink in path hierarchy#8082
Merged
repository: reject any updates that has symlink in path hierarchy#8082
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses a security vulnerability (GHSA-gg64-xxr9-qhjp) related to symlink path traversal attacks in the repository file editor. The fix prevents malicious users from exploiting symlinks in the path hierarchy to access or modify files outside the intended repository directories.
Key changes:
- Introduced
hasSymlinkInPathfunction to detect symlinks anywhere in the path hierarchy - Added security checks before file operations in UpdateRepoFile, GetDiffPreview, and DeleteRepoFile functions
- Simplified and fixed IsSymlink function in osutil package to avoid following symlinks during detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/osutil/osutil.go | Updated function documentation for clarity about symlink following behavior; simplified IsSymlink implementation to fix potential bug |
| internal/database/repo_editor.go | Added hasSymlinkInPath security function and integrated symlink checks into all file update/delete/preview operations; improved error handling and code consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
unknwon
commented
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Link to the GHSA: GHSA-gg64-xxr9-qhjp, closes #8071
Test plan
Tested manually.