api: fix nil pointer dereference when listing user repos#8069
Merged
api: fix nil pointer dereference when listing user repos#8069
Conversation
…ated repository.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a nil pointer dereference error in the /api/v1/user/repos endpoint. When a user has collaborator access to forked repositories, the attributes (specifically BaseRepo for forks) were not loaded before calling APIFormatLegacy, causing a crash.
Key changes:
- Added attribute loading for accessible repositories (repositories where the user is a collaborator) before formatting them for API response
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8069 +/- ##
==========================================
- Coverage 15.28% 0 -15.29%
==========================================
Files 106 0 -106
Lines 13864 0 -13864
==========================================
- Hits 2119 0 -2119
+ Misses 11465 0 -11465
+ Partials 280 0 -280 🚀 New features to boost your workflow:
|
unknwon
added a commit
that referenced
this pull request
Jan 21, 2026
Co-authored-by: Joe Chen <jc@unknwon.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
In
listUserRepositories, after querying the associated repo, attributes were not loaded, causingBaseRepoto be nil when executingapiRepo.Parent = r.BaseRepo.APIFormatLegacy(p)inAPIFormatLegacy. Add code to load attributes to fix this issue.Link to the issue: Closes #7830
Checklist
Test plan