Skip to content

Set timeout to explicit 0 in gogs.js#7890

Merged
unknwon merged 1 commit intogogs:mainfrom
Kizuren:main
Jan 2, 2025
Merged

Set timeout to explicit 0 in gogs.js#7890
unknwon merged 1 commit intogogs:mainfrom
Kizuren:main

Conversation

@Kizuren
Copy link
Contributor

@Kizuren Kizuren commented Dec 30, 2024

Describe the pull request

A simple fix in public/js/gogs.js making bug upload not result in a timeout (added just one line)

Link to the issue: closes #6149

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code or have provided the test plan.

Test plan

  • Set the max_size of attachment to a high number
[release.attachment]
ENABLED          = true
ALLOWED_TYPES    = */*
MAX_SIZE         = 512
MAX_FILES        = 20
  • Upload a file to releases

image

It doesn't randomly timeout!

@Kizuren Kizuren requested a review from unknwon as a code owner December 30, 2024 10:10
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit b59e943 into gogs:main Jan 2, 2025
@unknwon unknwon added this to the 0.13.3 milestone Jan 2, 2025
unknwon pushed a commit that referenced this pull request Jun 8, 2025
## Describe the pull request

A simple fix in public/js/gogs.js making bug upload not result in a
timeout (added just one line)

Link to the issue: closes #6149

## Test plan

- Set the max_size of `attachment` to a high number

```toml
[release.attachment]
ENABLED          = true
ALLOWED_TYPES    = */*
MAX_SIZE         = 512
MAX_FILES        = 20
```

- Upload a file to releases


![image](https://github.com/user-attachments/assets/8cf29c73-c8ec-42a3-9660-681a583b577a)

It doesn't randomly timeout!
@unknwon
Copy link
Member

unknwon commented Jun 9, 2025

The 0.13.3 has been released that includes this patch.

tarun-asthana pushed a commit to tarun-asthana/gogs that referenced this pull request Oct 4, 2025
## Describe the pull request

A simple fix in public/js/gogs.js making bug upload not result in a
timeout (added just one line)

Link to the issue: closes gogs#6149

## Test plan

- Set the max_size of `attachment` to a high number

```toml
[release.attachment]
ENABLED          = true
ALLOWED_TYPES    = */*
MAX_SIZE         = 512
MAX_FILES        = 20
```

- Upload a file to releases


![image](https://github.com/user-attachments/assets/8cf29c73-c8ec-42a3-9660-681a583b577a)

It doesn't randomly timeout!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed on uploading a large (1GB+) file in Releases

2 participants