auth: enable authentication by token from password#7198
Merged
Conversation
unknwon
approved these changes
Oct 22, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7198 +/- ##
==========================================
+ Coverage 11.86% 11.92% +0.05%
==========================================
Files 107 107
Lines 13626 13635 +9
==========================================
+ Hits 1617 1626 +9
+ Misses 11805 11799 -6
- Partials 204 210 +6 |
3 tasks
dna2github
pushed a commit
to dna2fork/gogs
that referenced
this pull request
May 1, 2023
Co-authored-by: Joe Chen <jc@unknwon.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
As #6421 is not getting update, I created this PR to close #3866 . This PR tries to authenticate using password as token at first, together with verifying username, and if that fails, it will try to fallback to try authenticate using username as token.
Checklist
Having trouble locating test cases, please help point out where to add tests.