repo: support unlisted but publicly accessible repositories by achilleas-k · Pull Request #6176 · gogs/gogs

achilleas-k · 2020-05-27T16:24:34Z

This PR adds support for publicly accessible but unlisted (secret) repositories (issue #5733).

Forms and UI

I'm including screenshots to show how the new checkbox appears in all relevant forms.

Creation

Settings

Settings (forked)

Icon

Note that, as I mentioned in the relevant issue, I included the icon for testing but it should probably be replaced by something more appropriate, like the eye-closed octicon in newer versions, or anything you might feel is more appropriate..

Behaviour

Unlisted repositories behave like Private repositories on pages that list repositories. The difference is that users who know the URL are allowed to view and clone them. The general idea is that Unlisted repositories should be "secret", in that no user should be able to discover them, but users who know about them can read them. In the interest of clarity and posterity, below I list how Unlisted repositories behave in all relevant cases.

For the owner of an unlisted repository:

They appear on the owner's repository list page.
They appear on the explore page (and search results).

For a collaborator of an unlisted repository:

They do not appear on the owner's repository list page.
They appear on the explore page (and search results).

For owners of organisations with unlisted repositories:

They appear on an organisation's repository list page.

For organisation team members with access to unlisted repositories:

They appear on an organisation's repository list page.

For other users and guest (non-logged-in) users:

They do not appear on the owner's repository list page.
They do not appear on the explore page (and search results).

General:

They do not appear in the owner's public activity (actions).
Repositories can be created unlisted.
Migrations can be created unlisted.
Forking an unlisted repository copies the unlisted property and the property can't be changed in the fork.
Changing a repository's unlisted status changes the status for all forks of the repository.
Changing a repository's unlisted status changes the visibility of associated actions.

API

Adding the Unlisted property to the API requires editing the structs in the go-gogs-client, which I'll do later and then reflect the changes here as necessary.

codecov · 2020-05-27T16:27:21Z

Codecov Report

Merging #6176 into main will increase coverage by 0.25%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #6176      +/-   ##
========================================
+ Coverage   8.65%   8.91%   +0.25%     
========================================
  Files         99      99              
  Lines      17767   17821      +54     
========================================
+ Hits        1537    1588      +51     
- Misses     16073   16074       +1     
- Partials     157     159       +2

unknwon · 2020-05-28T05:24:53Z

Thanks for the PR!

This seems much more than needed?

achilleas-k · 2020-05-28T05:34:57Z

That's mostly the last commit that regenerates static assets.

unknwon · 2020-05-28T05:37:53Z

Can you fix it? I can’t view these diffs on GitHub UI. (What I meant was the numbers look wrong)

unknwon · 2020-05-28T05:41:23Z

Please refer to https://github.com/gogs/gogs/blob/master/docs/dev/local_development.md and make sure you’re using the correct go-bindata. https://github.com/kevinburke/go-bindata

achilleas-k · 2020-05-28T06:14:55Z

Hm, it's possible I did a full regen while switching branches. I'll clean it up and rebase.

achilleas-k · 2020-05-28T06:36:21Z

Regenerated only required _gen files with the proper go-bindata. Sorry about that.

unknwon · 2020-06-11T11:43:57Z

Thanks for the follow up! I'll have this review when I have more bandwidth :)

boooong123 · 2020-08-30T11:25:11Z

When will this be live? Looks promising, just what a lot of people are looking for!

Thanks for adding this @achilleas-k

Repositories are shown for users with access (owners, collaborators).

Shown for owner.

- Add to form (needs restyling) - Trigger visibility change when Unlisted is toggled

- Copy Unlisted option when Forking and Migrating. - Update forks with Unlisted state when changed. - Change visibility of Actions when Unlisted state changes.

Visibility label for a box which includes Private and Unlisted options.

- Add option for creating repository as Unlisted on new repos and migrations. - Transfer the Unlisted setting when forking.

Unlisted option in forms for new repositories, migrations, and forks (read only).

Probably temporary. Should use something more appropriate, like the eye-closed from newer versions of octicon.

unknwon · 2020-08-30T12:24:08Z

When will this be live? Looks promising, just what a lot of people are looking for!

Thanks for adding this @achilleas-k

@TheRealJP It is :) Can't guarantee when though, but just added to my current 0.13 pipeline.

achilleas-k · 2020-08-30T12:24:36Z

Rebasing on main now to keep the PR up to date.

unknwon

Sorry that it's been a while! The code generally LGTM, just one little thing that we probably want to find a better icon later 😁 But not a blocker to me.

internal/db/repo.go

unknwon · 2020-09-03T19:04:38Z

Thanks again and congrats!

更新未列出存储库的翻译配置 gogs#5733 gogs#6176

unknwon added the status: needs followup label May 28, 2020

achilleas-k force-pushed the unlisted-repositories branch from f597682 to 6e899d5 Compare May 28, 2020 06:36

unknwon added status: waits for review and removed status: needs followup labels Jun 11, 2020

unknwon self-requested a review June 11, 2020 11:43

unknwon changed the base branch from master to main August 27, 2020 11:29

unknwon added this to the 0.13 milestone Aug 30, 2020

achilleas-k added 11 commits August 30, 2020 14:23

Add IsUnlisted column to Repository DB table

a97219f

Hide unlisted repositories from searches

eb01d6e

Repositories are shown for users with access (owners, collaborators).

Hide unlisted repositories on user page

f90a5f6

Shown for owner.

Actions are private for Private and Unlisted repos

32ab825

Hide Unlisted Org repositories

e348031

Add Unlisted option

386c0e3

- Add to form (needs restyling) - Trigger visibility change when Unlisted is toggled

Repo actions: Handle Unlisted option

320c148

- Copy Unlisted option when Forking and Migrating. - Update forks with Unlisted state when changed. - Change visibility of Actions when Unlisted state changes.

Repo visibility options redesign

9b9689a

Visibility label for a box which includes Private and Unlisted options.

Unlisted option on Create, Migrate, Fork

ae2d07c

- Add option for creating repository as Unlisted on new repos and migrations. - Transfer the Unlisted setting when forking.

Templates: Unlisted option on Create, Migrate, Fork

9e8a56a

Unlisted option in forms for new repositories, migrations, and forks (read only).

Use octicon-eye for unlisted repositories

21486fd

Probably temporary. Should use something more appropriate, like the eye-closed from newer versions of octicon.

Generate bindata

22c9229

achilleas-k force-pushed the unlisted-repositories branch from 6e899d5 to 22c9229 Compare August 30, 2020 12:37

unknwon approved these changes Sep 3, 2020

View reviewed changes

internal/db/repo.go Show resolved Hide resolved

unknwon added 2 commits September 4, 2020 02:57

Update internal/db/repo.go

b41d922

Update CHANGELOG.md

c2f13e6

unknwon linked an issue Sep 3, 2020 that may be closed by this pull request

Unlisted repositories #5733

Closed

unknwon changed the title ~~Unlisted, publicly accessible repositories~~ repo: support unlisted but publicly accessible repositories Sep 3, 2020

unknwon merged commit c436074 into gogs:main Sep 3, 2020

unknwon added status: reviewed and removed status: waits for review labels Sep 3, 2020

achilleas-k deleted the unlisted-repositories branch September 3, 2020 19:41

unknwon mentioned this pull request Sep 3, 2020

repo: set default value for is_unlisted column #6305

Merged

sandianyiyuan added a commit to sandianyiyuan/gogs that referenced this pull request Apr 26, 2022

Update locale_zh-CN.ini

88b1509

更新未列出存储库的翻译配置 gogs#5733 gogs#6176

sandianyiyuan mentioned this pull request Apr 26, 2022

Update locale_zh-CN.ini #6921

Closed

3 tasks

FinlayDaG33k mentioned this pull request Oct 12, 2022

Unlisted repositories not working #7181

Open

1 task

jgaehring mentioned this pull request Jan 22, 2023

Feature request: Add unlisted repositories go-gitea/gitea#8649

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023

Conversation

achilleas-k commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Forms and UI

Creation

Settings

Settings (forked)

Icon

Behaviour

API

Uh oh!

codecov bot commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

unknwon commented May 28, 2020

Uh oh!

achilleas-k commented May 28, 2020

Uh oh!

unknwon commented May 28, 2020

Uh oh!

unknwon commented May 28, 2020

Uh oh!

achilleas-k commented May 28, 2020

Uh oh!

achilleas-k commented May 28, 2020

Uh oh!

unknwon commented Jun 11, 2020

Uh oh!

boooong123 commented Aug 30, 2020

Uh oh!

unknwon commented Aug 30, 2020

Uh oh!

achilleas-k commented Aug 30, 2020

Uh oh!

unknwon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

unknwon commented Sep 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

achilleas-k commented May 27, 2020 •

edited

Loading

codecov bot commented May 27, 2020 •

edited

Loading

unknwon left a comment •

edited

Loading