📒 docs: Document usage of reverse proxies for SendEarlyHints#3778
📒 docs: Document usage of reverse proxies for SendEarlyHints#3778ReneWerner87 merged 31 commits intogofiber:mainfrom
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated documentation only: adjusted the SendEarlyHints caution in Changes
Sequence Diagram(s)(No sequence diagram — changes are documentation-only and do not modify control flow.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @akilesh1706, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Fiber documentation by introducing a dedicated guide on how to effectively use reverse proxies such as Nginx and Traefik to enable modern HTTP protocols like HTTP/2 and HTTP/3. This is crucial for ensuring that advanced Fiber features, specifically Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive documentation for configuring reverse proxies to enable HTTP/2 and HTTP/3 support in Fiber applications. The primary motivation is to help users properly configure features like SendEarlyHints that require modern HTTP protocols.
Key changes:
- Added new reverse proxy guide with Nginx and Traefik configuration examples
- Updated SendEarlyHints documentation to reference the new guide
- Provided clear instructions for enabling HTTP/2 and optional HTTP/3 support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/guide/reverse-proxy.md | New comprehensive guide covering reverse proxy setup for HTTP/2/3 with example configurations |
| docs/api/ctx.md | Updated SendEarlyHints documentation to reference the new reverse proxy guide |
|
@akilesh1706 Why did you open a new PR? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation on using reverse proxies like Nginx and Traefik to enable HTTP/2 for Fiber applications, which is essential for features like SendEarlyHints. The changes are well-structured, with a new guide and an update to existing API documentation. My review includes suggestions to enhance the new guide by adding a crucial section on configuring Fiber to trust proxy headers, improving document structure, and making a link more specific for better navigation. Please also note that the PR description mentions the new file as docs/guide/enabling-http2.md, but the actual file added is docs/guide/reverse-proxy.md; this might be worth correcting for consistency.
Previous PR looked messy. Had difficulty in tracking changes. |
Added details about reverse proxies, including benefits and popular options.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated the title and ID for the reverse proxy guide to include an emoji.
Removed unnecessary colon from the Popular Reverse Proxies section.
Updated reverse proxy guide to improve clarity and fix formatting issues.
Clarify requirements for using early hints feature.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/guide/reverse-proxy.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Review and update the contents of the
docsfolder if necessary when modifying code
Files:
docs/guide/reverse-proxy.md
Updated links for HAProxy and Caddy in the guide.
Clarify the behavior of legacy HTTP/1.1 clients with Early Hints.
|
Pending @grivera64 approval |
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
|
@grivera64 @gaby |
…#3778) * Documented reverse proxy workaround for SendEarlyHints * Doc: Update docs/guide/enabling-http2.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Doc: Update docs/guide/enabling-http2.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Doc: Update docs/guide/enabling-http2.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Doc: Update docs/guide/enabling-http2.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * 📒 docs: Document usage of reverse proxies for SendEarlyHints * Delete docs/guide/enabling-http2.md * Update docs/guide/reverse-proxy.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/guide/reverse-proxy.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update docs/guide/reverse-proxy.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update docs/api/ctx.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/guide/reverse-proxy.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Change HTTP/3 support header to H3 * Update reverse-proxy.md * Update docs/guide/reverse-proxy.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/guide/reverse-proxy.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update docs/api/ctx.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Revise reverse proxy guide for clarity and updates Updated the title and section headers for clarity. Added details on configuring Fiber to trust proxy headers and updated the list of popular reverse proxies. * Update docs/guide/reverse-proxy.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update reverse proxy documentation for clarity * Update docs/guide/reverse-proxy.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Enhance reverse proxy documentation with features and examples Added details about reverse proxies, including benefits and popular options. * Update docs/guide/reverse-proxy.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/guide/reverse-proxy.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revise reverse proxy guide title and ID Updated the title and ID for the reverse proxy guide to include an emoji. * Fix formatting in reverse-proxy.md Removed unnecessary colon from the Popular Reverse Proxies section. * Refine reverse proxy configuration documentation Updated reverse proxy guide to improve clarity and fix formatting issues. * Add caution about HTTP/2 requirement for early hints Clarify requirements for using early hints feature. * Fix links for HAProxy and Caddy in reverse proxy guide Updated links for HAProxy and Caddy in the guide. * Update caution note on sendEarlyHints feature Clarify the behavior of legacy HTTP/1.1 clients with Early Hints. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan Calderon-Perez <835733+gaby@users.noreply.github.com>
Description
This PR adds documentation to guide users on enabling HTTP/2 (and optionally HTTP/3) in Fiber applications using reverse proxies such as Nginx and Traefik.
The new page docs/guide/enabling-http2.md provides example configurations and references to official proxy documentation.
Additionally, the SendEarlyHints section in docs/api/ctx.md has been updated to link to this guide, helping users understand how to properly enable required protocols.
Fixes #3735
Changes introduced
List the new features or adjustments introduced in this pull request. Provide details on benchmarks, documentation updates, changelog entries, and if applicable, the migration guide.
Type of change
Checklist
Before you submit your pull request, please make sure you meet these requirements:
/docs/directory for Fiber's documentation.