Examples of matrix input usage in Spatial Shaders#5895
Merged
mhilbrunner merged 1 commit intogodotengine:masterfrom Jul 19, 2022
paddy-exe:matrices-usage-examples
Merged
Examples of matrix input usage in Spatial Shaders#5895mhilbrunner merged 1 commit intogodotengine:masterfrom paddy-exe:matrices-usage-examples
mhilbrunner merged 1 commit intogodotengine:masterfrom
paddy-exe:matrices-usage-examples
Conversation
clayjohn
reviewed
Jun 29, 2022
Contributor
Author
|
@clayjohn I incorporated your feedback in and moved the code together directly above the |
clayjohn
reviewed
Jul 4, 2022
clayjohn
reviewed
Jul 18, 2022
mhilbrunner
reviewed
Jul 19, 2022
Member
mhilbrunner
left a comment
There was a problem hiding this comment.
Very small nitpick, otherwise looks perfect!
mhilbrunner
approved these changes
Jul 19, 2022
Member
mhilbrunner
left a comment
There was a problem hiding this comment.
Thanks for the quick update, and good work on this PR :)
Calinou
pushed a commit
that referenced
this pull request
Jul 23, 2022
3.x version of this PR: #5895
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces examples for matrix input usage to users in Spatial Shaders such as: